Disassociate floatingip in HA router might get error

[Hong Hui Xiao]

With master code, I try to disassociate floatingip in HA router. But see following error in log.

2016-01-14 00:19:52.708 ERROR neutron.agent.linux.utils [-] Exit code: 2; Stdin: ; Stdout: ; Stderr: RTNETLINK answers: Cannot assign requested address

2016-01-14 00:19:52.710 ERROR neutron.agent.l3.router_info [-] Failed to process floating IPs.
2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info Traceback (most recent call last):
2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info File "/opt/stack/neutron/neutron/agent/l3/router_info.py", line 672, in process_external
2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info fip_statuses = self.configure_fip_addresses(interface_name)
2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info File "/opt/stack/neutron/neutron/agent/l3/router_info.py", line 251, in configure_fip_addresses
2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info raise n_exc.FloatingIpSetupException('L3 agent failure to setup '
2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info FloatingIpSetupException: L3 agent failure to setup floating IPs
2016-01-14 00:19:52.710 TRACE neutron.agent.l3.router_info

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/269988

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/269988
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=77f84fa9353dbf1d4c248c97ba59e857facefdb2
Submitter: Jenkins
Branch: master

commit 77f84fa9353dbf1d4c248c97ba59e857facefdb2
Author: Hong Hui Xiao <email address hidden>
Date: Tue Jan 19 22:17:20 2016 -0500

    Remove floatingip address only when the address has been configured

    For HA router, adding a floatingip will add a vip to keepalived, then
    keepalived will add the ip address to port. So there is a time window
    that the qg device in qrouter namespace will not have the address of
    floatingip.

    If user delete the floatingip at the time window, ip command will fail,
    because it tries to remove an ip address that doesn't exist on the qg device.

    The fix here is to check if the ip address is on the qg device, before
    removing the ip address. A functional test is added to address the issue.

    Change-Id: I72996d9a77f5f17b4d7a19d5be20b3f97f90dcba
    Closes-bug: #1533904