contrail-dns: crash in BindUtil::DnsClass

[amit surana]

contrail 2.21.1-22

core file location: 10.84.5.112:/cs-shared/bugs/1533811/

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/bin/contrail-dns'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x00007f2081dc85cb in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
(gdb) bt
#0 0x00007f2081dc85cb in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#1 0x00000000007118a0 in BindUtil::DnsClass (cl=<optimized out>) at controller/src/dns/bind/bind_util.cc:74
#2 0x0000000000712c67 in DnsItem::ToString (this=this@entry=0x7f200c01a9e0) at controller/src/dns/bind/bind_util.cc:60
#3 0x00000000006f4441 in DnsItemsToString (items=...) at controller/src/dns/bind/bind_util.h:181
#4 DnsManager::SendRetransmit (this=this@entry=0x7fffc3033330, xid=18023, op=<optimized out>, view=..., zone=..., items=...)
    at controller/src/dns/mgr/dns_mgr.cc:321
#5 0x00000000006f57a8 in DnsManager::ResendAllRecords (this=0x7fffc3033330) at controller/src/dns/mgr/dns_mgr.cc:379
#6 0x00000000006f5949 in DnsManager::PendingTimerExpiry (this=<optimized out>) at controller/src/dns/mgr/dns_mgr.cc:482
#7 0x00000000009a28b9 in operator() (this=<optimized out>) at /usr/include/boost/function/function_template.hpp:767
#8 Timer::TimerTask::Run (this=0x17d28d0) at controller/src/base/timer.cc:42
#9 0x000000000099cd10 in TaskImpl::execute (this=0x7f207abdfe40) at controller/src/base/task.cc:238
#10 0x00007f2082239b3a in ?? () from /usr/lib/libtbb.so.2
#11 0x00007f2082235816 in ?? () from /usr/lib/libtbb.so.2
#12 0x00007f2082234f4b in ?? () from /usr/lib/libtbb.so.2
#13 0x00007f20822310ff in ?? () from /usr/lib/libtbb.so.2
#14 0x00007f20822312f9 in ?? () from /usr/lib/libtbb.so.2
#15 0x00007f2082455182 in start_thread (arg=0x7f2049ff7700) at pthread_create.c:312
#16 0x00007f208152647d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/16390
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/16391
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/16410
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/16390
Committed: http://github.org/Juniper/contrail-controller/commit/367b68cb46c174251a9d64422ea0d63265623d17
Submitter: Zuul
Branch: master

commit 367b68cb46c174251a9d64422ea0d63265623d17
Author: Hari <email address hidden>
Date: Thu Jan 21 23:18:52 2016 +0530

Update task policy for contrail-dns.

When XMPP channel with agent clsoes, the records exported from there
are removed in the cleaner task context. Update the task policy to
ensure the config and bind tasks do not run in parallel with it.

Change-Id: Ic6c6de7de0754a0fc1f7022ac2a84070dc9dce03
closes-bug: 1533811

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/16410
Committed: http://github.org/Juniper/contrail-controller/commit/aa7686ef9a5bcc1d1a8235e551f8f9240b81c447
Submitter: Zuul
Branch: R2.21.x

commit aa7686ef9a5bcc1d1a8235e551f8f9240b81c447
Author: Hari <email address hidden>
Date: Fri Jan 22 19:49:21 2016 +0530

Update task policy for contrail-dns.

When XMPP channel with agent clsoes, the records exported from there
are removed in the cleaner task context. Update the task policy to
ensure the config and bind tasks do not run in parallel with it.

Change-Id: I049149d2c47051805aa3164f947b0572af597ac7
closes-bug: 1533811

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/16391
Committed: http://github.org/Juniper/contrail-controller/commit/026d52668635652bd2098e543f31838702c2b1eb
Submitter: Zuul
Branch: R2.20

commit 026d52668635652bd2098e543f31838702c2b1eb
Author: Hari <email address hidden>
Date: Fri Jan 22 10:06:10 2016 +0530

Update task policy for contrail-dns.

When XMPP channel with agent clsoes, the records exported from there
are removed in the cleaner task context. Update the task policy to
ensure the config and bind tasks do not run in parallel with it.

Change-Id: Ic92f147060c39e452742aa67ace7e3a6f3ddc5a3
closes-bug: 1533811

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/16686
Submitter: Vinay Vithal Mahuli (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/16686
Committed: http://github.org/Juniper/contrail-controller/commit/156ad0b760f9b532572116d813d7afa695555bea
Submitter: Zuul
Branch: R2.22.x

commit 156ad0b760f9b532572116d813d7afa695555bea
Author: Atul Moghe <email address hidden>
Date: Mon Dec 21 14:29:14 2015 -0800

Cherry pick controller commits from R2.20 to R2.22.x
updating version.info from 2.22 to 2.23 in 2.20 branch
Closes-Bug:#1528370

Change-Id: Ic649422979a926cc5f5b8457c01610b848dc206b

Storage stats daemon fix

Partial-Bug: #1528327
Fixed latency monitor code based on the Ceph 0.94.3 version.
Fixed issues in OSD throughput/IOPs calculation.
Updated code based on the latest Sandesh apis.

Change-Id: I12caf951f84c8b213b1b5ec01371bb68b4c48cb3

Fix contrail-collector back pressure mechanism

contrail-collector DB queue back presssure mechanism was not
working since the DB drop level is initialized to INVALID and
even the water marks levels are INVALID and hence the defer/undefer
callbacks are not called.

Change-Id: Ib28141a69aeed3c4ad6f50abbaed2a285e3e7db2
Partial-Bug: #1528380

Fix Agent crash for flow index tree management

Issue:
------
During a flow index change vrouter-agent triggers a delete
on index tree using new flow handle instead of currently
held flow_handle resulting in flow entry getting associated
to two slots in the flow index tree, which further on flow
entry delete due to aging or eviction never releases the
slot for old flow handle, causing failures for further
insertions in the flow index tree

Fix:
----
Avoid taking flow handle as argument to DeleteByIndex and
use the currently associated flow_handle to remove from tree
Adding assert in DeleteByIndex to catch delete failure
Avoid doing delete from index tree in code paths other than
flow entry index update of flow entry delete.

Add logic for KSync Sock User to Mock vrouter behavior
returning index for an entry if it is already allocated
instead of allocating a new one.

Closes-Bug: 1527425
Change-Id: I10e77fb59650acfdd924a5f1d35d6b8dea03a3f0

Fix discovery dependency issue. Originally made in master branch
via https://review.opencontrail.org/#/c/15749

Change-Id: I5d874de3714074c66fa73bfd7c9119772dc681fd
Partial-Bug: #1530186

Avoid calling get_routing_instances on VN object

Calling get_routing_instances could trigger another read of the VN
if the VN has no routing instance. This is not only inefficient, but
could also cause exception if the VN has disappeared. We can avoid
this by calling getattr.

Change-Id: Ie5500585b9e6c578576276c2c04ec03f32c75112
Partial-Bug: 1528950

Fix Centos 65 agent compilation issues.
Closes-Bug: #1532159

Change-Id: Ia8b77619c80737000d5bd949534c9e0a16967359

Closes-Bug: #1524063, contrail-status is showing contrail-web-ui, even it is not configured, in case of SMLite

Change-Id: I55afc19140b1ce52b3b529a644124705de5ce6a8

Fix a corner case with routing instance delete

Sequence of event that causes the crash
1. Static route config deleted
2. Static Route maanger triggers resolve_trigger_ to re-evaluate static
route config
3. Before the resolve trigger is invoked routing instance is deleted

Resolve trigger calls ProcessStaticRouteConfi...