2.3.3 innobackupex silently skip extra argument

[Fungo Wang]

If in invoke innobackupex like this:

innobackupex --defaults-file=/etc/my.cnf --slave-info --lock-wait-timeout=900 --host=127.0.0.1 --port=3306 --user=root --test tmp abc 123

IMPORTANT: Please check that the backup run completes successfully.
           At the end of a successful backup run innobackupex
           prints "completed OK!".

innobackupex run as nothing wrong, which should failed, cause I supply an unknown option '--test' and two extra arguments 'abc' and '123'.

And I don't think this is expected behaviour.

For 2.2, innnobackex complain error as:

Unknown option: test
innobackupex: got a fatal error with the following stacktrace: at /usr/bin/innobackupex line 4403
        main::check_args() called at /usr/bin/innobackupex line 1562
innobackupex: Error: Too many command line arguments

it spit out the unknown option '--test' and complain about extra arguments.

For the extra arguments, I think can be fixed as attechment.

[Shahriyar Rzayev (rzayev-sehriyar)]

It is an expected behaviour,
It is processing only known options and will just ignore unknown.

[Fungo Wang (fungo)]

ignoring make sense for options, but not for extra arguments.

there are code for extra argument,

 ibx_msg("Error: extra argument found %s\n",
         opt);

but it did not work.

[Sergei Glushchenko (sergei.glushchenko)]

Since "unknown options" isn't something xtrabackup has to complain about, I changed the title to mention only extra position arguments.

[Sergei Glushchenko (sergei.glushchenko)]

https://github.com/percona/percona-xtrabackup/pull/146

[Sergei Glushchenko (sergei.glushchenko)]

https://github.com/percona/percona-xtrabackup/pull/160

[monty solomon (monty+launchpad)]

The mysql client in Percona Server reports unknown options. It would be useful to report them in innobackupex too.

# mysql --test
mysql: unknown option '--test'

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-747