SQLAlchemy implicit unicode conversion

Bug #1533193 reported by Federico Ceratto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Medium
Federico Ceratto

Bug Description

During testing, SQLAlchemy warns about unicode conversions:

SAWarning: Unicode type received non-unicode bind param value '192.168.2.170'. (this warning may be suppressed after 10 occurrences)

Different databases and Python versions treat unicode in different ways and this could lead to bugs.

Those "managed_*" fields are Unicode and maybe should be Strings:
https://github.com/openstack/designate/blob/master/designate/storage/impl_sqlalchemy/tables.py#L183

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to designate (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/266353

Tim Simmons (timsim)
Changed in designate:
importance: Undecided → Medium
milestone: none → mitaka-3
assignee: nobody → Federico Ceratto (federico-ceratto)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/276448

Changed in designate:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/276448
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=a999159607908ac9a82fdab979eaa52f289586b7
Submitter: Jenkins
Branch: master

commit a999159607908ac9a82fdab979eaa52f289586b7
Author: Federico Ceratto <email address hidden>
Date: Thu Feb 4 21:02:19 2016 +0000

    Switch "managed" fields from unicode to string

    Change-Id: I8c6e921dab3084d4006567b98da3d6fa85e96574
    Closes-Bug: 1533193

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to designate (master)

Reviewed: https://review.openstack.org/266353
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=b442fe709bd7ec258104f5a064c5330e52b55563
Submitter: Jenkins
Branch: master

commit b442fe709bd7ec258104f5a064c5330e52b55563
Author: Federico Ceratto <email address hidden>
Date: Tue Jan 12 12:59:04 2016 +0000

    Minor unicode test fixes

    Change-Id: I9d4eb3a4e0985960fa06bf17fe3454d61c34a5a4
    Related-Bug: #1533193

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/designate 2.0.0.0b3

This issue was fixed in the openstack/designate 2.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.