V8 deprecation warnings

Bug #1532910 reported by Chris Coulson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Fix Released
High
Alexandre Abreu

Bug Description

Current trunk builds result in the following deprecation warnings:

[7/29] CXX obj/shared/renderer/oxide_shared.oxide_script_message_handler_renderer.o
../../../../shared/renderer/oxide_script_message_handler_renderer.cc: In member function ‘bool oxide::ScriptMessageHandlerRenderer::ReceiveMessageCallback(oxide::ScriptMessage*, scoped_ptr<base::Value>*)’:
../../../../shared/renderer/oxide_script_message_handler_renderer.cc:61:16: warning: ‘v8::TryCatch::TryCatch()’ is deprecated (declared at ../../../../third_party/chromium/src/v8/include/v8.h:6517): Use isolate version [-Wdeprecated-declarations]
   v8::TryCatch try_catch;
                ^
[13/29] CXX obj/shared/renderer/oxide_shared.oxide_script_message_impl_renderer.o
In file included from ../../../../shared/renderer/oxide_script_referenced_object.h:26:0,
                 from ../../../../shared/renderer/oxide_script_message_impl_renderer.h:28,
                 from ../../../../shared/renderer/oxide_script_message_impl_renderer.cc:18:
../../../../shared/renderer/oxide_v8_scoped_persistent.h: In instantiation of ‘void oxide::ScopedPersistent<T>::SetWeak(P*, typename v8::WeakCallbackData<T, P>::Callback) [with P = scoped_refptr<oxide::ScriptMessageImplRenderer>; T = v8::Object; typename v8::WeakCallbackData<T, P>::Callback = void (*)(const v8::WeakCallbackData<v8::Object, scoped_refptr<oxide::ScriptMessageImplRenderer> >&)]’:
../../../../shared/renderer/oxide_script_referenced_object.h:49:7: required from ‘static void oxide::ScriptReferencedObjectBase::Finish(U*) [with U = oxide::ScriptMessageImplRenderer]
../../../../shared/renderer/oxide_script_referenced_object.h:81:62: required from ‘oxide::ScriptReferencedObject<T>::ScriptReferencedObject(oxide::ScriptMessageManager*, v8::Handle<v8::Object>&) [with T = oxide::ScriptMessageImplRenderer; v8::Handle<v8::Object> = v8::Local<v8::Object>]’
../../../../shared/renderer/oxide_script_message_impl_renderer.cc:50:65: required from here
../../../../shared/renderer/oxide_v8_scoped_persistent.h:66:5: warning: ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackData<T, P>::Callback) [with P = scoped_refptr<oxide::ScriptMessageImplRenderer>; T = v8::Object; typename v8::WeakCallbackData<T, P>::Callback = void (*)(const v8::WeakCallbackData<v8::Object, scoped_refptr<oxide::ScriptMessageImplRenderer> >&)]’ is deprecated (declared at ../../../../third_party/chromium/src/v8/include/v8.h:7392): use WeakCallbackInfo version [-Wdeprecated-declarations]
     handle_.SetWeak(parameters, callback);
     ^
In file included from ../../../../shared/renderer/oxide_script_message_impl_renderer.h:24:0,
                 from ../../../../shared/renderer/oxide_script_message_impl_renderer.cc:18:
../../../../third_party/chromium/src/v8/include/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackData<T, P>::Callback) [with P = scoped_refptr<oxide::ScriptMessageImplRenderer>; T = v8::Object; typename v8::WeakCallbackData<T, P>::Callback = void (*)(const v8::WeakCallbackData<v8::Object, scoped_refptr<oxide::ScriptMessageImplRenderer> >&)]’:
../../../../shared/renderer/oxide_v8_scoped_persistent.h:66:5: required from ‘void oxide::ScopedPersistent<T>::SetWeak(P*, typename v8::WeakCallbackData<T, P>::Callback) [with P = scoped_refptr<oxide::ScriptMessageImplRenderer>; T = v8::Object; typename v8::WeakCallbackData<T, P>::Callback = void (*)(const v8::WeakCallbackData<v8::Object, scoped_refptr<oxide::ScriptMessageImplRenderer> >&)]’
../../../../shared/renderer/oxide_script_referenced_object.h:49:7: required from ‘static void oxide::ScriptReferencedObjectBase::Finish(U*) [with U = oxide::ScriptMessageImplRenderer]
../../../../shared/renderer/oxide_script_referenced_object.h:81:62: required from ‘oxide::ScriptReferencedObject<T>::ScriptReferencedObject(oxide::ScriptMessageManager*, v8::Handle<v8::Object>&) [with T = oxide::ScriptMessageImplRenderer; v8::Handle<v8::Object> = v8::Local<v8::Object>]’
../../../../shared/renderer/oxide_script_message_impl_renderer.cc:50:65: required from here
../../../../third_party/chromium/src/v8/include/v8.h:7395:10: warning: ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackData<S, P>::Callback) [with S = v8::Object; P = scoped_refptr<oxide::ScriptMessageImplRenderer>; T = v8::Object; typename v8::WeakCallbackData<S, P>::Callback = void (*)(const v8::WeakCallbackData<v8::Object, scoped_refptr<oxide::ScriptMessageImplRenderer> >&)]’ is deprecated (declared at ../../../../third_party/chromium/src/v8/include/v8.h:7380): use WeakCallbackInfo version [-Wdeprecated-declarations]
   SetWeak<T, P>(parameter, callback);
          ^
[15/29] CXX obj/shared/renderer/oxide_shared.oxide_script_message_request_impl_renderer.o
../../../../shared/renderer/oxide_script_message_request_impl_renderer.cc: In member function ‘void oxide::ScriptMessageRequestImplRenderer::DispatchResponse(v8::Handle<v8::Function>, int, v8::Local<v8::Value>*)’:
../../../../shared/renderer/oxide_script_message_request_impl_renderer.cc:42:16: warning: ‘v8::TryCatch::TryCatch()’ is deprecated (declared at ../../../../third_party/chromium/src/v8/include/v8.h:6517): Use isolate version [-Wdeprecated-declarations]
   v8::TryCatch try_catch;
                ^
In file included from ../../../../shared/renderer/oxide_script_referenced_object.h:26:0,
                 from ../../../../shared/renderer/oxide_script_message_request_impl_renderer.h:28,
                 from ../../../../shared/renderer/oxide_script_message_request_impl_renderer.cc:18:
../../../../shared/renderer/oxide_v8_scoped_persistent.h: In instantiation of ‘void oxide::ScopedPersistent<T>::SetWeak(P*, typename v8::WeakCallbackData<T, P>::Callback) [with P = scoped_refptr<oxide::ScriptMessageRequestImplRenderer>; T = v8::Object; typename v8::WeakCallbackData<T, P>::Callback = void (*)(const v8::WeakCallbackData<v8::Object, scoped_refptr<oxide::ScriptMessageRequestImplRenderer> >&)]’:
../../../../shared/renderer/oxide_script_referenced_object.h:49:7: required from ‘static void oxide::ScriptReferencedObjectBase::Finish(U*) [with U = oxide::ScriptMessageRequestImplRenderer]’
../../../../shared/renderer/oxide_script_referenced_object.h:81:62: required from ‘oxide::ScriptReferencedObject<T>::ScriptReferencedObject(oxide::ScriptMessageManager*, v8::Handle<v8::Object>&) [with T = oxide::ScriptMessageRequestImplRenderer; v8::Handle<v8::Object> = v8::Local<v8::Object>]’
../../../../shared/renderer/oxide_script_message_request_impl_renderer.cc:101:74: required from here
../../../../shared/renderer/oxide_v8_scoped_persistent.h:66:5: warning: ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackData<T, P>::Callback) [with P = scoped_refptr<oxide::ScriptMessageRequestImplRenderer>; T = v8::Object; typename v8::WeakCallbackData<T, P>::Callback = void (*)(const v8::WeakCallbackData<v8::Object, scoped_refptr<oxide::ScriptMessageRequestImplRenderer> >&)]’ is deprecated (declared at ../../../../third_party/chromium/src/v8/include/v8.h:7392): use WeakCallbackInfo version [-Wdeprecated-declarations]
     handle_.SetWeak(parameters, callback);
     ^
In file included from ../../../../shared/renderer/oxide_script_message_request_impl_renderer.h:25:0,
                 from ../../../../shared/renderer/oxide_script_message_request_impl_renderer.cc:18:
../../../../third_party/chromium/src/v8/include/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackData<T, P>::Callback) [with P = scoped_refptr<oxide::ScriptMessageRequestImplRenderer>; T = v8::Object; typename v8::WeakCallbackData<T, P>::Callback = void (*)(const v8::WeakCallbackData<v8::Object, scoped_refptr<oxide::ScriptMessageRequestImplRenderer> >&)]’:
../../../../shared/renderer/oxide_v8_scoped_persistent.h:66:5: required from ‘void oxide::ScopedPersistent<T>::SetWeak(P*, typename v8::WeakCallbackData<T, P>::Callback) [with P = scoped_refptr<oxide::ScriptMessageRequestImplRenderer>; T = v8::Object; typename v8::WeakCallbackData<T, P>::Callback = void (*)(const v8::WeakCallbackData<v8::Object, scoped_refptr<oxide::ScriptMessageRequestImplRenderer> >&)]’
../../../../shared/renderer/oxide_script_referenced_object.h:49:7: required from ‘static void oxide::ScriptReferencedObjectBase::Finish(U*) [with U = oxide::ScriptMessageRequestImplRenderer]’
../../../../shared/renderer/oxide_script_referenced_object.h:81:62: required from ‘oxide::ScriptReferencedObject<T>::ScriptReferencedObject(oxide::ScriptMessageManager*, v8::Handle<v8::Object>&) [with T = oxide::ScriptMessageRequestImplRenderer; v8::Handle<v8::Object> = v8::Local<v8::Object>]’
../../../../shared/renderer/oxide_script_message_request_impl_renderer.cc:101:74: required from here
../../../../third_party/chromium/src/v8/include/v8.h:7395:10: warning: ‘void v8::PersistentBase<T>::SetWeak(P*, typename v8::WeakCallbackData<S, P>::Callback) [with S = v8::Object; P = scoped_refptr<oxide::ScriptMessageRequestImplRenderer>; T = v8::Object; typename v8::WeakCallbackData<S, P>::Callback = void (*)(const v8::WeakCallbackData<v8::Object, scoped_refptr<oxide::ScriptMessageRequestImplRenderer> >&)]’ is deprecated (declared at ../../../../third_party/chromium/src/v8/include/v8.h:7380): use WeakCallbackInfo version [-Wdeprecated-declarations]
   SetWeak<T, P>(parameter, callback);
          ^
[16/29] CXX obj/shared/renderer/oxide_shared.oxide_script_referenced_object.o
../../../../shared/renderer/oxide_script_referenced_object.cc: In constructor ‘oxide::ScriptReferencedObjectBase::ScriptReferencedObjectBase(oxide::ScriptMessageManager*, v8::Handle<v8::Object>)’:
../../../../shared/renderer/oxide_script_referenced_object.cc:44:33: warning: ‘bool v8::Object::SetHiddenValue(v8::Local<v8::String>, v8::Local<v8::Value>)’ is deprecated (declared at ../../../../third_party/chromium/src/v8/include/v8.h:2929): Use v8::Object::SetPrivate instead. [-Wdeprecated-declarations]
         data_.NewHandle(isolate));
                                 ^
../../../../shared/renderer/oxide_script_referenced_object.cc: In static member function ‘static oxide::ScriptReferencedObjectBase* oxide::ScriptReferencedObjectBase::FromScriptHandle(v8::Handle<v8::Object>&)’:
../../../../shared/renderer/oxide_script_referenced_object.cc:64:61: warning: ‘v8::Local<v8::Value> v8::Object::GetHiddenValue(v8::Local<v8::String>)’ is deprecated (declared at ../../../../third_party/chromium/src/v8/include/v8.h:2931): Use v8::Object::GetPrivate instead. [-Wdeprecated-declarations]
       v8::String::NewFromUtf8(isolate, kWrappedNativeObject)));
                                                             ^
[17/29] CXX obj/shared/renderer/oxide_shared.oxide_script_message_manager.o
../../../../shared/renderer/oxide_script_message_manager.cc: In member function ‘v8::Handle<v8::Object> oxide::ScriptMessageManager::GetOxideApiObject(v8::Isolate*)’:
../../../../shared/renderer/oxide_script_message_manager.cc:126:16: warning: ‘v8::TryCatch::TryCatch()’ is deprecated (declared at ../../../../third_party/chromium/src/v8/include/v8.h:6517): Use isolate version [-Wdeprecated-declarations]
   v8::TryCatch try_catch;
                ^
[22/29] CXX obj/shared/renderer/oxide_shared.oxide_user_script_slave.o
../../../../shared/renderer/oxide_user_script_slave.cc: In member function ‘void oxide::UserScriptSlave::InjectGreaseMonkeyScriptInMainWorld(blink::WebLocalFrame*, const blink::WebScriptSource&)’:
../../../../shared/renderer/oxide_user_script_slave.cc:143:16: warning: ‘v8::TryCatch::TryCatch()’ is deprecated (declared at ../../../../third_party/chromium/src/v8/include/v8.h:6517): Use isolate version [-Wdeprecated-declarations]
   v8::TryCatch try_catch;
                ^
[26/29] SOLINK lib/libOxideQtCore.so.0

I don't know how much longer we've got before this stops building

Related branches

Changed in oxide:
importance: Undecided → High
status: New → Triaged
Changed in oxide:
assignee: nobody → Alexandre Abreu (abreu-alexandre)
Changed in oxide:
status: Triaged → In Progress
Changed in oxide:
status: In Progress → Fix Released
milestone: none → branch-1.16
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.