A python keyword is used for a variable name

[[e-mail]]

horizon/openstack_dashboard/dashboards/project/volumes/volumes/forms.py:

there is a python keyword "type" used for a variable name on line#112, it might be a irrelevant coding style issue, but I think it might be problem in future, or have issue when you write unitest. Besides, this should not be allowed by PEP8 and openstack code style.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/265923

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/266447

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/266665

[OpenStack Infra (hudson-openstack)]

Change abandoned by <email address hidden> (<email address hidden>) on branch: master
Review: https://review.openstack.org/266447
Reason: I re-commit a new one, this one is abandoned.

[OpenStack Infra (hudson-openstack)]

Change abandoned by <email address hidden> (<email address hidden>) on branch: master
Review: https://review.openstack.org/265923
Reason: Already commit a new one supersede this.

[David Lyle (david-lyle)]

"type" is not actually a python keyword, it is a built-in function which will be overridden for the scope of the method. Since the built-in type function is not called in the method, it currently is not a problem.

Additionally, no PEP8 check should check for this as overriding methods is perfectly allowable in python.

Ideally we would not name variables the same as built-in functions, but in my opinion this is not really a bug, but instead a subjective style issue. Not wrong, but after the fact cleanup provides little benefit. Should the use of "type" in the method change, the fact that "type" is no longer callable will be raised in the form of the exception and at that time the developer requiring type could change the existing variable name.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Liao Zhuodi (<email address hidden>) on branch: master
Review: https://review.openstack.org/266665