Replace oslo_utils.timeutils because it is deprecated

[Craig Vyvial]

Replace trove.common.timeutils due to the deprecation in oslo_utils.timeutils.
https://review.openstack.org/#/c/182602/

[Craig Vyvial (cp16net)]

This patch addresses this change.

https://review.openstack.org/#/c/257152/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Zhihai Song (<email address hidden>) on branch: master
Review: https://review.openstack.org/257152

[Amrith Kumar (amrith)]

Sorry, didn't realize there was a bug for this already.

[Amrith Kumar (amrith)]

See: https://review.openstack.org/#/c/326655/

[OpenStack Infra (hudson-openstack)]

Change abandoned by amrith (<email address hidden>) on branch: master
Review: https://review.openstack.org/326655
Reason: "abandoned for inactivity, over 3 weeks old, has a negative review comment and is not currently marked as a WIP or WF-1. please restore the change if you wish to work on it. (project:openstack/trove-specs OR project:openstack/trove OR project:openstack/trove-dashboard OR project:openstack/python-troveclient OR project:openstack/trove-integration) status:open age:3w label:Code-Review=-1 (NOT label:Workflow<0)"

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326655
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=109ff949511c0185ab1dd0beffeb03a8a3332005
Submitter: Jenkins
Branch: master

commit 109ff949511c0185ab1dd0beffeb03a8a3332005
Author: Amrith Kumar <email address hidden>
Date: Tue Jun 7 08:15:24 2016 -0400

    Handle isotime deprecation in oslo_utils.timeutils

    oslo_utils.timeutils is deprecating isotime(). In reality they are
    deprecating some other things as well but Trove doesn't (currently)
    use any of those things.

    Much has been written on the subject of this deprecation. I think the
    proposal to merely replace isotime with datetime.datetime.isoformat()
    is a little simplistic. Well intentioned, but nonetheless I believe
    that it is simplistic.

    The primary issue I could find with oslo_utils.timeutils.isotime() was
    the fact that it was naive. I think it could well have been fixed in
    oslo_utils but for whatever reason(s) oslo decided not to want to go
    that route.

    The primary challenge from Trove's perspective is that I want to
    respect the existing API contract while at the same time get an
    implementation of time handling that is not identical in its flaws
    with oslo_utils.timeutils.isotime().

    This change set attempts to address that by making
    trove.common.timeutils.isotime() that is aware. It also implements a
    utcnow_aware() function that is aware.

    ISO 8601 allows for four representations of timezone and those are

    <time>Z
    <time>[+-]hh:mm
    <time>[+-]hhmm
    <time>[+-]hh

    Trove conventionally used the first one, even if the time wasn't
    really a UTC time. That's one of the things being fixed here.

    In review cp16net asked whether this change removes the 'Z' at the end
    of time strings generated by the isotime() function. The answer is
    NO. The new isotime() function performs identical to the old and now
    deprecated function in oslo_utils.timeutils for UTC (Z) times.

    There was a utcnow() function in trove.common.utils which just wrapped
    datetime.datetime.utcnow(). That has been moved now to
    trove.common.timeutils with the other new time related functions.

    There were a couple of places in Trove where code was using
    datetime.now() which was not ideal. Those have been corrected now as
    well.

    Unit tests have been proposed for the new routines.

    Closes-Bug: #1532120
    Change-Id: Ic5abf6669edd4f1a9fd62e61f437565aa887aebe

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/trove 8.0.0.0b3 development milestone.