taglib 1.10 backport for xenial

Bug #1532107 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
High
RJ Skerry-Ryan

Bug Description

Since we do not want to support an Taglib 1.9 installation, we should not encourage the user to download a the *.deb file on
http://www.mixxx.org/download/

Instead we may link to
https://launchpad.net/~mixxx/+archive/ubuntu/mixxx/+packages
which provides all needed deb packages on a single page.

This becomes more important once we include the midi overflow patch, which will make Mixxx crashy with the original Ubuntu libpotmidi version.

Changed in mixxx:
importance: Undecided → High
milestone: none → 2.0.1
Revision history for this message
Owen Williams (ywwg) wrote :

I disagree. We can recommend that users use the PPA and warn them of what problems they might see if they use an older version of taglib but we don't want to actively make it harder for some users to download mixxx.

As a project we have not made a decision that "we do not want to support a taglib 1.9 installation." I respect that it is your personal view but that opinion is not shared by the consensus of the other developers.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

What would you do, if someone complains about a crash during library scan and we found out that the user is still on taglib 1.9?

Download the Mixxx *.deb on Launchpad is not harder at all. One might say it is easier, since it offers dedicated packages for each Ubuntu version, which will make the user feel more comfortable that he is doing right.
On the top of it this source is also secure due to the signed resource and the encrypted method to upload.

Alternatively, we can offer the libtag 1.10 along with the mixxx deb on our download server.
But I see no reason to wast bandwidth and maintenance effort for something that already exists.

By the way: how do we guarantee that the provided downloads on mixxx.org are not infected by viruses?

Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

> What would you do, if someone complains about a crash during library scan and we found out that the user is still on taglib 1.9?

We would tell them to upgrade their taglib and offer our PPA to help. Problem solved. We've done this in the past with PortAudio and that issue was actually higher priority. (Making it more difficult for some people to install Mixxx is not an option.)

Changed in mixxx:
status: New → Won't Fix
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Sorry, I have to reopen it.

It is not a good approach to let the user run into an issue and tell him afterwards how to fix it.

If we tell the user somehow that he have to install taglib 1.10 along with his mixxx *.deb download this bug is solved.

(My idea was just, lets make it easy and link to the ppa download debs.
What is the point that makes it hard here? )

Changed in mixxx:
status: Won't Fix → New
summary: - remove *.deb only download link from mixxx.org
+ tell *.deb user to download taglib 1.10 download link from mixxx.org
summary: - tell *.deb user to download taglib 1.10 download link from mixxx.org
+ tell *.deb user to download taglib 1.10 as well
Revision history for this message
Be (be.ing) wrote : Re: tell *.deb user to download taglib 1.10 as well

What is the status of this?

Changed in mixxx:
milestone: 2.0.1 → 2.1.0
Revision history for this message
Daniel Schürmann (daschuer) wrote :

https://launchpad.net/ubuntu/xenial/+source/taglib

Xenial the latest LTS version has still taglib 1.9
How is the situation on other OSs?

Revision history for this message
Be (be.ing) wrote :

A user on the forum reported that 2.1 does not compile on Xenial 16.04 LTS:
https://mixxx.org/forums/viewtopic.php?p=34608&f=1#p34608

Changed in mixxx:
status: New → Confirmed
Revision history for this message
Be (be.ing) wrote :

What is the status of this? Is there anything we should do about it for 2.1?

Revision history for this message
Be (be.ing) wrote :

Ping. Is there anything to do for this?

Revision history for this message
Be (be.ing) wrote :

I am removing this from the 2.1 milestone. Reassign it if there is actually something that needs to be done for this.

Changed in mixxx:
milestone: 2.1.0 → none
Revision history for this message
Daniel Schürmann (daschuer) wrote :

We have no Xenial taglib backport on our ppa.
I think we just need to upload the backport for xenial as well and we can close this bug.

Changed in mixxx:
milestone: none → 2.1.1
Revision history for this message
Daniel Schürmann (daschuer) wrote :

I could do this, I just need write access to our PPA.
Or can anyone else jump in here?

Changed in mixxx:
milestone: 2.1.1 → 2.1.2
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

wget https://launchpad.net/~mixxx/+archive/ubuntu/mixxx/+sourcefiles/taglib/1.10-0ubuntu1~vivid0/taglib_1.10-0ubuntu1~vivid0.debian.tar.gz
wget https://launchpad.net/~mixxx/+archive/ubuntu/mixxx/+sourcefiles/taglib/1.10-0ubuntu1~vivid0/taglib_1.10.orig.tar.gz
tar zxf taglib_1.10-0ubuntu1~vivid0.debian.tar.gz
tar zxf taglib_1.10.orig.tar.gz
cd taglib-1.10
mv ../debian ./
sed -i s/vivid/xenial/g debian/control
sed -i s/vivid/xenial/g debian/changelog
debuild -S -sa
cd ..
dput ppa:mixxx/mixxx taglib_1.10-0ubuntu1\~xenial0_source.changes
rm taglib_1.10-0ubuntu1\~xenial0_source.ppa.upload
dput ppa:mixxx/mixxxbetas taglib_1.10-0ubuntu1\~xenial0_source.changes

Changed in mixxx:
assignee: nobody → RJ Skerry-Ryan (rryan)
status: Confirmed → Fix Released
milestone: 2.1.2 → 2.1.1
summary: - tell *.deb user to download taglib 1.10 as well
+ taglib 1.10 backport for xenial
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Cool, we get rid of this. Thank you very much.

Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8430

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.