Have a function to handle IPv6 address brackets.

[Sofer Athlan-Guyot]

Hi,

when using ipv6, one has often to put brackets around the ip when it puts it in url. It would be very convenient to have a function that does it.

Here the interface I have in mind with the puppet-nova module:

class nova::vncproxy::common (
  $vncproxy_host = undef,
  $vncproxy_protocol = undef,
  $vncproxy_port = undef,
  $vncproxy_path = undef,
) {

  include ::nova::deps

  $vncproxy_host_real = pick(
    ipv6_add_bracket_maybe($vncproxy_host,
                           $::nova::compute::vncproxy_host,
                           $::nova::vncproxy::host,
                           false)

This would returns an array with the host decorated with "[]" if the
value is an IPv6 address. Ideally the function could take only one
value and return it or take an array and return an array for seamless
integration in the code.

[Cody Herriges (ody-cat)]

https://review.openstack.org/#/c/264927/

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-openstacklib 7.1.0 release.