mapping_id does not allow "_" character

[Roxana Gherle]

The underscore character is not allowed in mapping_id because the validation of the parameter value is done with the id_string regex pattern '^[a-zA-Z0-9-]+$' which doesn't include '_'.

Underscore character should be allowed in a mapping id validation.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/264937

[Henry Nash (henry-nash)]

Could I ask what the use case is for this? domain_id's are generated by keystone, they cannot be provided by the caller...

[Roxana Gherle (roxana-gherle)]

hey Henry, I hit this when creating a federation protocol using a mapping_id containing an underscore. mapping_id is provided by the user. maybe my reference to domain_id was not necessary.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/264937
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=b81a8266d1e6248ca759d51ef1a003423887ee8a
Submitter: Jenkins
Branch: master

commit b81a8266d1e6248ca759d51ef1a003423887ee8a
Author: Roxana Gherle <email address hidden>
Date: Thu Jan 7 11:09:54 2016 -0800

    Allow '_' character in mapping_id value

    Underscore character should be allowed in mapping_id.

    Closes-Bug: #1531959
    Change-Id: I4235e09ff68f68bbe4cf5c4e9aeaef2b79484f94

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/keystone 9.0.0.0b3 development milestone.