Convergence get_attr fails for some stack resources

[Rakesh H S]

In convergence all the outputs are stored in cache_data and fetched as shown here https://github.com/openstack/heat/blob/master/heat/engine/resource.py#L1597.

However, in some stack resource plugins FnGetAtt is overridden, as a result get_attr on these resources will fail.

I could list some of the resource plugins are:
https://github.com/openstack/heat/blob/master/heat/engine/resources/template_resource.py#L316
https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/heat/resource_group.py#L411

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/264748

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/264748
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5d070f9c59b3218d45c23c2936e223552fe81d81
Submitter: Jenkins
Branch: master

commit 5d070f9c59b3218d45c23c2936e223552fe81d81
Author: Rakesh H S <email address hidden>
Date: Thu Jan 7 17:54:06 2016 +0530

    Convergence: Fix FnGetAtt to fetch value from cache_data

    Resource plugins will now override rsrc.get_attribute method to add
    extra logic to Fn::GetAtt specific to resource implementation.

    Also provides proper comment to rsrc.get_reference_id method.

    Change-Id: I7561afa1c824b2294dd6701be6a19723abbe0522
    Closes-Bug: #1531840

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/heat 6.0.0.0b3 development milestone.