Hugin crashes when merging projects with line control points

Bug #1531567 reported by Noah
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Hugin
Fix Released
Undecided
Unassigned

Bug Description

(Hugin 2015.0.0 on Windows 7).

I'm trying to merge two projects, one of which contains line control points (not horizontal or vertical lines). It has more than 1 type of these line control points (eg, "Line 3", "Line 4", etc. in the control point "mode" dropdown or the "alignment" column of the control points table). The merge crashes every time. If I remove the "Line 4+" control points (Line 3 is fine, horizontal and vertical line is fine), the projects merge okay.

How to reproduce:

1) Create a new project, import one picture, and save it.

2) Create another new project, import one picture, and go into the Control Points tab. This should show the one image in both the left and right views.

3) Click in the left image, then click in the right image to add a line control point. This will default to horizontal or vertical.

4) If you open the 'mode' dropdown at lower right, you can pick "Add new Line" down at the bottom. When you do this, the control point's "Alignment" will now be "Line 3".

5) Repeat 3) and 4) to create another line control point. This time when you do "Add new Line" it will have alignment "Line 4".

6) Save the project.

7) Go to File>Merge Project, and merge with the other project you created in 1).

8) Hugin crashes.

If I had to guess, I would say the bug has to do with pto_merge not understanding how to merge control points in the project where the type is > "t3" (if you open up the project file in a text editor you can see each control point has one of these, t0= normal, t1 = horizontal, t2 = vertical, t3+ = "Line 3+".

Obviously this won't be fixed soon, and there's a kind of hackish workaround, but I thought I'd report it.

Thanks!

P.S. the workaround I'm using is the following:

1) In the project with the extra line control points, go into the control points table and remove all the line control points with Alignment of Line 4 or greater. (Click on the Alignment column to sort by that, then shift-click to select all the ones to delete).

2) Merge with the other project. It should merge fine. But you're missing your line control points.

3) Save *as a new project*.

4) Close Hugin

5) Go into a text editor, open the old project with the line control points in it.

6) Also open the new merged project.

7) Find the bottom of the control points section in the old project. If the last control point was one of the ones you deleted, keep going up until you get to one that ends with "t0", "t1", "t2", or "t3" (ie, one you didn't delete in the merged project).

8) Copy that line, go back to the new project text file, and find it. It should be the last line before the beginning of control points from the project you were trying to merge in.

9) Go back to the old project text file, and copy all of the control points.

10) Go back to the merged project text file, and *replace* all the control points above the line you identified with all the control points you just copied. This will not change any of the other control points, but will add in the offending line control points.

11) If the second project also had line control points, use the same procedure to paste them in from the text version of that project, too.

12) Save the merged project in your text editor, and open it in Hugin. It should be the merger of the two projects, with all the line control points in place!

Noah (ngw25)
description: updated
Noah (ngw25)
description: updated
Noah (ngw25)
summary: - Crashes when merging projects with line control points
+ Hugin crashes when merging projects with line control points
Revision history for this message
tmodes (tmodes) wrote :

The crash is fixed in changeset 4883e17eee61b82f3eb60964b68cc3673380250b in repository.
Changeset 09be16172552d78a77f38eb83ee8c9b3c27d7ac9 fixes another issue with line cp and merging.

Changed in hugin:
status: New → Fix Committed
Revision history for this message
Noah (ngw25) wrote :

Thank you! I would assume that, as someone who isn't compiling their own version, I'll have to wait for the 2016.0.0 executable to see this change?

tmodes (tmodes)
Changed in hugin:
milestone: none → 2016.0beta1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.