Do not load unneeded packages with map loading
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
There are some packages that need to be loaded with the map when loading a savegame, but do not need to be loaded when starting a new game or opening a map in the editor.
An attempt to fix was made by putting the compatibility code back in:
https:/
A better fix would be not to save or load these packages at all when there is no actual game involved, because they cause compatibility problems.
The following packages have been identified as candidates for not to be included:
log("Writing Flag Data ... ");
log("Writing Road Data ... ");
log("Writing Map Objects ... "); - this is probably needed in editor, or isn't it?
// DATA PACKETS 3 sections here
log("Writing Node Ownership Data ... ");
log("Writing Exploration Data ... ");
log("Writing Players Unseen Data ... ");
log("Writing Scripting Data ... ");
log("Writing Objective Data ... ");
Related branches
- SirVer: Approve
-
Diff: 866 lines (+261/-239)15 files modifieddata/maps/MP_Scenarios/Island_Hopping.wmf/player/1/messages (+0/-4)
data/maps/MP_Scenarios/Island_Hopping.wmf/scripting/first_island.lua (+1/-1)
data/maps/MP_Scenarios/Island_Hopping.wmf/scripting/texts.lua (+38/-36)
src/editor/editorinteractive.cc (+2/-1)
src/game_io/game_map_packet.cc (+1/-1)
src/io/filesystem/layered_filesystem.cc (+7/-6)
src/logic/game.cc (+5/-2)
src/logic/map_info.cc (+1/-1)
src/map_io/map_building_packet.cc (+2/-7)
src/map_io/map_loader.h (+7/-1)
src/map_io/map_saver.cc (+82/-72)
src/map_io/s2map.cc (+1/-1)
src/map_io/s2map.h (+1/-1)
src/map_io/widelands_map_loader.cc (+112/-104)
src/map_io/widelands_map_loader.h (+1/-1)
Changed in widelands: | |
status: | Confirmed → In Progress |
assignee: | nobody → GunChleoc (gunchleoc) |
Changed in widelands: | |
status: | In Progress → Fix Committed |
assignee: | GunChleoc (gunchleoc) → nobody |
Changed in widelands: | |
status: | Fix Committed → Fix Released |
I am unsure if there are some packages will be needed in future in editor. See https:/ /wl.widelands. org/forum/ topic/1703/ regarding loading tribes. So if tribes are loaded as default, there are may several packages which depend on the tribes, aren't there?