Remove using hiera('nodes') from osnailyfacter module

[Sergey Vasilenko]

Using hiera('nodes') is deprecated.
We should stop use it, because this approach not fully compatible with flexible networking (network roles).

Bugfix should contains two serial patches:
1. Patch to fuel library, that removes all using of hiera('nodes')
2. Patch to Nailgun, that stop generates of nodes array

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/263876

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/263876
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=d89b25921c2cd982dca92a55a46b98ed50a060a2
Submitter: Jenkins
Branch: master

commit d89b25921c2cd982dca92a55a46b98ed50a060a2
Author: Sergey Vasilenko <email address hidden>
Date: Tue Jan 5 17:56:18 2016 +0300

    No more use nodes list.

    Nodes list is deprecated, beause incompatible with network-roles model.
    Network metadata should be used instead.

    This patchset implements:
    * remove nodes list from fixtures
    * remove unused function filter_nodes
    * remove some unused code, related to nodes list
    * new parser function get_node_key_name() for generating immutable node key name
    * fix parser function roles_include() for using network_metadata
    * use roles_include() if need instead directly lookup into network_metadata
    * fix some manifests for use network_matadata/nodes

    Change-Id: I2e6b1cd5cb75263efc995aa9f62bd3073abed1b8
    Related-bug: #1531128
    Related-bug: #1538220

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/301573

[Dmitry Pyzhov (dpyzhov)]

Technical debt, doesn't affect real users. Removing from Mitaka release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/308931

[Artem Roma (aroma-x)]

AFAIC, 'nodes' data is skipped by the manifests (after according change to the library) and deployment tasks utilizing the info has type skipped [1] for releases >= 9.0 (thus is not processed by the Nailgun). All that implies that serialization of the attribute has no real impact on production environment.

However it is hard to introduce the change to Nailgun. Mainly because of this bug [2]; as separate fixture for tests for serializers of versions >= 9.0 must be used and there is no mechanism yet to process such separate fixtures by the testing infrastructure (for more details, please, see description for mentioned related bug).

With that being said the importance of the bug, IMO, should be lowered to medium with all efforts to focus on the related bug.

[1]: https://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/modular/astute/tasks.yaml#L36-L40
[2]: https://bugs.launchpad.net/fuel/+bug/1517874

[OpenStack Infra (hudson-openstack)]

Change abandoned by Aleksey Kasatkin (<email address hidden>) on branch: master
Review: https://review.openstack.org/301573
Reason: It was a POC. Fix is introduced in https://review.openstack.org/308931

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/310200

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/310200
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=8be916680a076d825b1941c139c8911c56e746fa
Submitter: Jenkins
Branch: master

commit 8be916680a076d825b1941c139c8911c56e746fa
Author: Aleksandr Didenko <email address hidden>
Date: Tue Apr 26 15:22:38 2016 +0200

    Fix deprecated nodes list in yaql expressions

    'nodes' list is deprecated and replaced with
    'network_metadata/nodes' hash. Update yaql_exp accordingly.

    Change-Id: I795f944ca3b1fc49fae07ddc36c2eabcfcc968ed
    Partial-bug: #1531128

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/308931
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=3a8b82887b8a507a122382428bee7b6ca938908d
Submitter: Jenkins
Branch: master

commit 3a8b82887b8a507a122382428bee7b6ca938908d
Author: Artem Roma <email address hidden>
Date: Thu Apr 28 15:40:24 2016 +0300

    Remove 'nodes' from deployment 9.0 serializer output

    Now serialized deployment info for environments >= 9.0 does not contain
    'nodes' field; it is removed from the output of the serializer.

    Unit and integration tests are updated. Deployment tasks fixture
    changed: 'nodes' references in yaql expressions changed to
    'network_metadata.nodes'

    Change-Id: Ibdb2cf85732c0293314298e6a342b071ece18cc3
    Closes-Bug: #1531128

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/316110

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/316110
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=aa3310b5d537bf186ffdbac5c7fd836cb6cae378
Submitter: Jenkins
Branch: master

commit aa3310b5d537bf186ffdbac5c7fd836cb6cae378
Author: Aleksandr Didenko <email address hidden>
Date: Fri May 13 15:23:08 2016 +0200

    Use proper nodes list source in enable_quorum task

    We no longer use 'nodes' list in hiera (astute.yaml), nodes info
    if in hash inside of 'network_metadata' hash. This patch updates
    enable_quorum.rb script accordingly.

    Change-Id: Iaf78a02a8c1d617e00010a7fd5bb94183607927a
    Partial-bug: #1531128

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/317429

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/317429
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=80d7188700a699f0c3da763f5103e793b3c1d9c0
Submitter: Jenkins
Branch: master

commit 80d7188700a699f0c3da763f5103e793b3c1d9c0
Author: Artem Roma <email address hidden>
Date: Tue May 17 15:21:25 2016 +0300

    Remove 'nodes' key from serializer for 10.0

    'nodes' data is deprecated so must be removed from 10.0 version
    serializer output. The change was moved to separate serializer class in
    order to maintain compatibility with previously deployed 9.0 clusters
    after upgrade to 10.0.

    Change-Id: I8fef591908cd8b1e4ace5502bb1e80cb37786c6e
    Related-Bug: #1531128