watcher

The command "watcher action-plan-start uuid" can be run several time even if the state of ActionPlan selected is succeed

Bug #1531106 reported by Jean-Emile DARTOIS
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
Fix Released
Medium
Vincent Françoise
watcher mitaka-2 "m2"

Bug Description

The command "watcher action-plan-start uuid" can be run several time even if the state of ActionPlan selected is succeed. The reason of this bug is that the current implementation does not check the state of ActionPlan before the execution of the action plan.
We need to fix that

See original description
Tags: api
Jean-Emile DARTOIS (jed56)
Changed in watcher:
milestone: none → mitaka-2
importance: Undecided → Medium
Jean-Emile DARTOIS (jed56)
summary: - ActionPlan Start
+ The command watcher action-plan-start uuid can be run several time
summary: - The command watcher action-plan-start uuid can be run several time
+ The command "watcher action-plan-start uuid" can be run several time
+ even if the state is succeed
description: updated
summary: The command "watcher action-plan-start uuid" can be run several time
- even if the state is succeed
+ even if the state of selected ActionPlan is succeed
summary: The command "watcher action-plan-start uuid" can be run several time
- even if the state of selected ActionPlan is succeed
+ even if the state of ActionPlan selected is succeed
Jean-Emile DARTOIS (jed56)
description: updated
Vincent Françoise (vincent-francoise)
Changed in watcher:
assignee: nobody → Vincent Françoise (vincent-francoise)
Vincent Mahe (vincent-mahe)
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to watcher (master)

Fix proposed to branch: master
Review: https://review.openstack.org/270815

Changed in watcher:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to watcher (master)

Reviewed: https://review.openstack.org/270815
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=83fdbf736662e46c5f2da2a74c11d3757dd77112
Submitter: Jenkins
Branch: master

commit 83fdbf736662e46c5f2da2a74c11d3757dd77112
Author: Vincent Françoise <email address hidden>
Date: Thu Jan 21 14:33:14 2016 +0100

    Action plan state transition - payload validation

    This patchset fixes the lack of field validation that are provided
    by an API user.

    Via a PATCH on /action_plans, the only field that can be modified
    is now the 'state'. This field can only perform to the following
    state transitions:

    - RECOMMENDED --> TRIGGERED
    - RECOMMENDED --> CANCELLED
    - ONGOING --> CANCELLED
    - TRIGGERED --> CANCELLED

    The DELETED state can only be set using a DELETE request.

    Closes-Bug: #1531106
    Change-Id: I6669cbe63407f0bbb792fb2e2ce6b1e8a7365238

Changed in watcher:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.