After a photo is straightened and the apply button is pushed, the original photo is displayed

Bug #1531010 reported by José M. Benítez
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Photos
Fix Released
Medium
José M. Benítez

Bug Description

Well, it's basically so:

1. Take a photo and click the "straighten" tool.
2. Choose a random value for the slider (the photo is turned accordingly).
3. Apply the edition clicking the button.
4. The previous state of the photo is displayed :(

The edition is actually applied though.

Nathan Dyer (nathandyer)
Changed in pantheon-photos:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → loki-beta1
Changed in pantheon-photos:
assignee: nobody → José M. Benítez (jmiguelbenitez)
Changed in pantheon-photos:
status: Confirmed → In Progress
Revision history for this message
José M. Benítez (jmiguelbenitez) wrote :

The bug is solved in the related branch, but it takes approximately four seconds for my laptop to display the rotated image.

I don't think this is because of the added code, but due to the transformation itself. I'll have to look to see if there's something I can do in that regard, but I guess this may very well be a considerable task.

I guess we'll have to decide at some point if we merge this branch as it is and leave the other issue for another bug or even a blueprint.

Maybe we should also add some sort of indication that the process is going to take too long or display a low-quality rotated image while getting the final image (or whatever is done when you view a single photo).

Changed in pantheon-photos:
milestone: loki-beta1 → loki-rc1
Revision history for this message
Cody Garver (codygarver) wrote :

I didn't experience any delay. But if it is a prevalent issue, it should become a new bug report.

Changed in pantheon-photos:
status: In Progress → Fix Committed
Cody Garver (codygarver)
Changed in pantheon-photos:
milestone: loki-rc1 → loki-beta2
Cody Garver (codygarver)
Changed in pantheon-photos:
milestone: loki-beta2 → loki-alpha1
Cody Garver (codygarver)
Changed in pantheon-photos:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.