novaclient wrapper incorrectly handles exceptions

[Valeriy Ponomaryov]

If Novaclient returns exception, then manila wrapper for novaclient fails with following error:

 File "/opt/stack/new/manila/manila/compute/nova.py", line 160, in wrapper
     return res
 ERROR oslo_messaging.rpc.dispatcher UnboundLocalError: local variable 'res' referenced before assignment

link: http://logs.openstack.org/83/261183/4/check/gate-manila-tempest-dsvm-neutron-no-share-servers-multibackend/caac355/logs/screen-m-shr.txt.gz?level=TRACE#_2016-01-04_08_53_26_056

code: https://github.com/openstack/manila/blob/8247f350/manila/compute/nova.py#L160

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/263207

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/263207
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=95940a4085b1800277baeb7467fa06e96936734c
Submitter: Jenkins
Branch: master

commit 95940a4085b1800277baeb7467fa06e96936734c
Author: vponomaryov <email address hidden>
Date: Mon Jan 4 12:46:03 2016 +0200

    Fix handling of Novaclient exceptions

    If Novaclient returns exception, then Manila wrapper for Novaclient
    fails with following error:

    File "/opt/stack/new/manila/manila/compute/nova.py", line 160, in wrapper
        return res
    UnboundLocalError: local variable 'res' referenced before assignment

    So, fix it and cover with unit tests.

    Change-Id: I5eec4b9e9f3857307daa2ade516f76c044c01631
    Closes-Bug: #1530811

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/manila 2.0.0.0b2 development milestone.