LB policy is not working in a correct way

[Qiming Teng]

Currently the load balancing policy is detaching nodes from the load-balancer *after* nodes are deleted. This is wrong. We should detach nodes from the load-balancer *before* the nodes are deleted.

[Yanyan Hu (yanyanhu)]

Yes, detaching lb member from loadbalancer before corresponding node is deleted is the correct logic. The problem is in some cases, we don't know which node(s) will be deleted before the action is executed, e.g. resize cluster with random victim choosing. So I guess we may need to eliminate those random deleting logic before fix this problem. Will think about it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/263631

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/263631
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=84b39d1eb718df74503c07c84d7e0853ef8dc70b
Submitter: Jenkins
Branch: master

commit 84b39d1eb718df74503c07c84d7e0853ef8dc70b
Author: yanyanhu <email address hidden>
Date: Tue Jan 5 03:07:31 2016 -0500

    Set cluster to correct status when scaling failed

    Currently, cluster status will not be set to correct value when
    resizing/scaling action failed for size limitation check failure.
    This patch fixes this issue.

    Change-Id: I9de9a8684c8aa6ffeae9b5f7df9331e51eb168b3
    Closes-Bug: #1530746

[Yanyan Hu (yanyanhu)]

A BP has been filed for this issue:

https://blueprints.launchpad.net/senlin/+spec/rework-policy-check-for-built-in-policy-types

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/senlin 1.0.0.0b2 development milestone.