Create button in "Create Subnet" dialog on "Subnet Details" tab is disabled when "Disable Gateway" is selected

[Liam Haworth]

When creating a subnet via the "Create Subnet" dialog, if the check box "Disable Gateway" is checked and the user clicks on the "Subnet Details" tab in the dialog the next button is disabled and displayed as "Create >>".

[Liam Haworth (liam-haworth)]

root@ctrl1:~# dpkg -s openstack-dashboard
Package: openstack-dashboard
Status: install ok installed
Priority: extra
Section: net
Installed-Size: 27864
Maintainer: Chuck Short <email address hidden>
Architecture: all
Source: horizon
Version: 2:8.0.0-0ubuntu2~cloud0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/263249

[Liam Haworth (liam-haworth)]

Hey Wang,

I can see you guys are doing some great work, just wanted to ask what milestone this bug will be targeted at

[Wang Bo (chestack)]

Liam Haworth, the fix patch is in review. It depends on core reviewers to speed up merging the codes.

[Rob Cresswell (robcresswell-deactivatedaccount)]

This appears to be a major feature failure, though I'd need to double check my understanding of Neutron workflows is correct.

[Liam Haworth (liam-haworth)]

Rob, no backport to Liberty where the bug was first discovered?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/263249
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fb804ac4ada82c862905a1f24069ee78c6e8fe4e
Submitter: Jenkins
Branch: master

commit fb804ac4ada82c862905a1f24069ee78c6e8fe4e
Author: Bo Wang <email address hidden>
Date: Mon Jan 4 21:02:44 2016 +0800

    Fix workflow bug in "Create Network" dialog

    In "Subnet Info" tab, the button "Next" will hide and
    button "Create" will show if checked Disable Gateway.
    Because value of hide_tab is undefined but transformed to
    hide_tab = ['undefined'] in js code.

    Remove unused ',' which will introduce empty element in list:
    String(['a', 'b',]).split(,) --> ['a', 'b', '']

    Switching field "address_source" should not trigger
    field "gateway_ip" show/disappear.

    Closes-Bug: #1487005
    Closes-Bug: #1530729
    Closes-Bug: #1569942
    Change-Id: If9e417e151e11c8ee46ded50ee3ee8108ed777a4

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/316768

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/316768
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a5974142664360128154eafcbfb9cd3156c5ddaa
Submitter: Jenkins
Branch: stable/mitaka

commit a5974142664360128154eafcbfb9cd3156c5ddaa
Author: Bo Wang <email address hidden>
Date: Mon Jan 4 21:02:44 2016 +0800

    Fix workflow bug in "Create Network" dialog

    In "Subnet Info" tab, the button "Next" will hide and
    button "Create" will show if checked Disable Gateway.
    Because value of hide_tab is undefined but transformed to
    hide_tab = ['undefined'] in js code.

    Remove unused ',' which will introduce empty element in list:
    String(['a', 'b',]).split(,) --> ['a', 'b', '']

    Switching field "address_source" should not trigger
    field "gateway_ip" show/disappear.

    Closes-Bug: #1487005
    Closes-Bug: #1530729
    Closes-Bug: #1569942
    Change-Id: If9e417e151e11c8ee46ded50ee3ee8108ed777a4
    (cherry picked from commit fb804ac4ada82c862905a1f24069ee78c6e8fe4e)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 9.0.1 release.