cinder::volume::rbd does not use $::os_service_default for all parameters

[Mike Dorman]

The cinder::volume::rbd class does not use $::os_service_default on the volume_tmp_dir and rbd_secret_uuid parameters, but instead default these to false. If you use this class without specifying those parameters, they are passed along to cinder::backend::rbd which then configures literal 'false' values for those configuration parameters in cinder.conf:

volume_tmp_dir=False
rbd_secret_uuid=False

These are string parameters in cinder.conf, so the above is interpreted as a literal directory name of 'False', and a uuid of 'False', respectively. This obviously breaks the cinder config.

cinder::volume::rbd should use $::os_service_default for these parameters, so the correct defaults will be applied.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/262563

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/262563
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=218c08580f0c4947ba9324fd7df5a0b39cb1e157
Submitter: Jenkins
Branch: master

commit 218c08580f0c4947ba9324fd7df5a0b39cb1e157
Author: Mike Dorman <email address hidden>
Date: Wed Dec 30 09:35:19 2015 -0700

    Use $::os_service_default for all cinder::volume::rbd parameters

    The volume_tmp_dir and rbd_secret_uuid parameters have a default
    value of false, instead of using $::os_service_default. This causes
    a broken cinder config if this class is included and non-default
    values are not specified for these parameters.

    This patch changes the default values to use $::os_service_default

    Change-Id: I3ccb5f98348416a6e95849df1d1fe44f79b89be5
    Closes-bug: 1530168