BGPaaS: bgpaas-server bgp-router not cleaned up

[amit surana]

contrail 3.0-2689

Deletion of the BgpAsAService object does not clean up the bgpaas-server bgp-router. This causes problems if the VN is deleted; because the RI is the parent of the bgp-router, the former is also not cleaned up. If the VN with the same name is now created (along with vmi and BgpAsAService object), it points to a new RI while the bgpaas-server bgp-router continues to point to the stale RI.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/16117
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/16117
Committed: http://github.org/Juniper/contrail-controller/commit/f1ac6fc6c35553aae184ceaa369931920c8366d2
Submitter: Zuul
Branch: master

commit f1ac6fc6c35553aae184ceaa369931920c8366d2
Author: Sachin Bansal <email address hidden>
Date: Wed Jan 6 14:13:38 2016 -0800

Delete bgpaas-server object when VN is deleted

It is possible that one bgpaas-client object is being created while another one
is being deleted. To avoid race condition during this, we will leave the
bgpaas-server object when the client is deleted. These objects will be deleted
when the VN iteself is deleted. There are no resources held by such object, so
it should be ok to keep them even when they are not being used.

Also fixed a traceback in api server due to not catching cassandra
NotFoundException during update_last_modified.

Change-Id: Iaeea4b13d35443cd015b6b4e1145249d1bfc2606
Closes-Bug: 1529983