Remove node_role usage in fuel-library noop rspec tests

Bug #1529888 reported by Aleksandr Didenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Aleksandr Didenko

Bug Description

Introduced by https://review.openstack.org/255996 where 'node_role' was removed from Hiera. But we still have a bunch of rspec tests that rely on 'node_role' hiera key and thus they do not work at the moment. For example:

enable = (Noop.hiera_structure('murano/enabled') and Noop.hiera('node_role') == 'primary-controller')

from murano_rspec.rb test currently return 'false' even for primary controllers, so we no longer run tests for primary controller role.

Tags: area-library
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/262252

Changed in fuel:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/262252
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=c26c4c5e8ce4966e3cc2de4ef16a6ad9f8ba20c1
Submitter: Jenkins
Branch: master

commit c26c4c5e8ce4966e3cc2de4ef16a6ad9f8ba20c1
Author: Aleksandr Didenko <email address hidden>
Date: Tue Dec 29 16:50:43 2015 +0100

    Remove 'node_role' Hiera key from noop tests

    Since I8b51651adc2634544f510de8838ebaabcd1e7d43 we no longer have
    'node_role' key in Hiera. So we should fix all rspec tests that
    are using this key.

    Change-Id: I1e22e9c94f834563df5b6d7192b690aed7db6dd6
    Closes-bug: #1529888

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Mikhail Samoylov (msamoylov) wrote :

Verified.

1. Download fuel-library code or open https://git.openstack.org/cgit/openstack/fuel-library/tree/tests/noop/spec/hosts
2. Check that code really changed.

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.