[Task Based] Failed to run selected task that has type "group"

Bug #1529783 reported by Bulat Gaifullin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Bulat Gaifullin

Bug Description

Steps to reproduce:

install plugin that provides group task, for example
https://github.com/openstack/fuel-plugins/tree/master/examples/fuel_plugin_example_v4

Start single task via CLI.
fuel node --node-id=1 --task "fuel_plugin_example_v4"

expected result:
the task was completed successfully.

Actual result:
the task fails.

traceback

  File "/usr/lib/python2.7/site-packages/nailgun/task/manager.py", line 57, in _call_silently
    to_return = method(task, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/nailgun/task/task.py", line 186, in message
    task, nodes, task_ids, reexecutable_filter
  File "/usr/lib/python2.7/site-packages/nailgun/task/task.py", line 245, in task_deploy
  File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/task_based_deployment.py", line 398, in serialize
    serializer.resolve_nodes(
  File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/task_based_deployment.py", line 427, in resolve_nodes
    tasks_for_role = task.get('tasks')
  File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/task_based_deployment.py", line 503, in expand_task_groups
    :param task_mapping: the mapping task id to task object
InvalidData: Task %s cannot be resolved

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/262160

Changed in fuel:
status: New → In Progress
Dmitry Pyzhov (dpyzhov)
tags: added: team-enhancements
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/262160
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4026e2e0e1676b08f323d95503fbf9745974603e
Submitter: Jenkins
Branch: master

commit 4026e2e0e1676b08f323d95503fbf9745974603e
Author: Bulat Gaifullin <email address hidden>
Date: Tue Dec 29 11:25:39 2015 +0300

    Moved filtration of tasks into TaskSerializer

    Since expanding groups needs all tasks, the filtration of tasks was
    moved into TaskSerializer.
    To preserve connectivity of graph keep all task in graph, only mark it as skipped.

    Change-Id: Icfbe0a9d49df2b4ac3e71f28424b7d99ecbb543a
    Closes-Bug: #1529783

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/271716

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/8.0)

Reviewed: https://review.openstack.org/271716
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=9c78c70c46a3463f9cfcfac78974fe27d32a5f05
Submitter: Jenkins
Branch: stable/8.0

commit 9c78c70c46a3463f9cfcfac78974fe27d32a5f05
Author: Bulat Gaifullin <email address hidden>
Date: Tue Dec 29 11:25:39 2015 +0300

    Moved filtration of tasks into TaskSerializer

    Since expanding groups needs all tasks, the filtration of tasks was
    moved into TaskSerializer.
    To preserve connectivity of graph keep all task in graph, only mark it as skipped.

    Change-Id: Icfbe0a9d49df2b4ac3e71f28424b7d99ecbb543a
    Closes-Bug: #1529783
    (cherry picked from commit 4026e2e0e1676b08f323d95503fbf9745974603e)

tags: added: on-verification
Revision history for this message
Dmitriy Kruglov (dkruglov) wrote :
tags: removed: on-verification
tags: added: on-verification
Revision history for this message
Andrey Sledzinskiy (asledzinskiy) wrote :

verified on 8.0-506

Changed in fuel:
status: Fix Committed → Fix Released
tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.