FWTS syntaxcheck failure on Remark #2011 ASL_MSG_COMPILER_RESERVED
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Firmware Test Suite |
Fix Released
|
Medium
|
Colin Ian King |
Bug Description
Reporting IASL remark #2011 as failure is quite confusing. If there are real problems of using compiler reserved symbols, these problems should be caught when comping ACPI source. It would be better to just log the remark as info.
-------
12510|
12511| Method (_DSM, 4, Serialized) // _DSM: Device-Specific Method
12512| {
12513| Name (_T_2, Zero) // _T_x: Emitted by ASL Compiler
| ^
| Remark 2011: Use of compiler reserved name (_T_2)
=======
ADVICE: (for Remark #2011, ASL_MSG_
disassembled code is being compiled and it contains compiler-emitted names of
the form '_T_x'. This is just a remark generated by the compiler and can
normally be ignored.
Changed in fwts: | |
status: | New → In Progress |
importance: | Undecided → Critical |
importance: | Critical → Medium |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in fwts: | |
status: | Fix Committed → Fix Released |
From accad713ae86d7d c0b500a14ab1505 d680d26197 Mon Sep 17 00:00:00 2001 COMPILER_ RESERVED failure
From: Fan Wu <email address hidden>
Date: Wed, 8 Jul 2015 15:24:02 -0600
Subject: [PATCH] FWTS:syntaxcheck change the ASL_MSG_
to info
--- syntaxcheck/ syntaxcheck. c | 6 +++++-
src/acpi/
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/acpi/ syntaxcheck/ syntaxcheck. c b/src/acpi/ syntaxcheck/ syntaxcheck. c syntaxcheck/ syntaxcheck. c syntaxcheck/ syntaxcheck. c table(fwts_ framework *fw, int which)
fwts_failed( fw, LOG_LEVEL_HIGH, label, "Assembler error in line %d", num);
break;
case ASL_REMARK: error_code_ to_error_ number( error_code) == ASL_MSG_ COMPILER_ RESERVED) {
break;
case ASL_OPTIMIZATION:
skip = true;
index c189e87..8be4330 100644
--- a/src/acpi/
+++ b/src/acpi/
@@ -545,7 +545,11 @@ static int syntaxcheck_
- fwts_failed(fw, LOG_LEVEL_LOW, label, "Assembler remark in line %d", num);
+ if ( syntaxcheck_
+ fwts_log_info(fw, "Assembler remark(info) in line %d", num);
+ } else {
+ fwts_failed(fw, LOG_LEVEL_LOW, label, "Assembler remark in line %d", num);
+ }
--
1.8.2.1