manage existing doesn't honor default volume type

[Michal Dulko]

manage_existing calls are defaulting to volume_type=None in case the volume type isn't specified in the request. In my opinion we should have similar behavior as in case of create - default to the default_volume_type from configuration.

[Sean McGinnis (sean-mcginnis)]

What if the default volume type has an extra spec of "{'volume_backend_name': 'x'}" but we're managing the volume from backend 'y'? It seems safer to me to keep the current behavior and do a retype if needed.

[Michal Dulko (michal-dulko-f)]

@Sean: Good point. We could also make it go through scheduler to decide, similarly to migrate. In manage we actually have both host and volume type, so this sounds like a similar situation.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/252458
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity for > 6 months.