gw remote-mac-entry implementation

Bug #1529491 reported by Ryu Ishimoto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-midonet
Fix Released
High
Ryu Ishimoto

Bug Description

Remote MAC entry implementation for the gateway device extension is incomplete.

Changed in networking-midonet:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-midonet (master)

Fix proposed to branch: master
Review: https://review.openstack.org/261851

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/261852

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/261853

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/261855

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/261856

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/261861

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/261862

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/261865

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/261866

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/261867

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/261868

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/261869

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-midonet (master)

Reviewed: https://review.openstack.org/261851
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=bb8e18d1f66c66dc4d1b537abd3d0b753c9d5879
Submitter: Jenkins
Branch: master

commit bb8e18d1f66c66dc4d1b537abd3d0b753c9d5879
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 17:29:39 2015 +0000

    Organize methods in GwDeviceDbMixin

    For better readability, organize the member variables of
    GwDeviceDbMixin in an alphabetical order.

    Change-Id: Ibf860a193d037367fd4c4addd661dd1ace47a89e
    Partial-Bug: #1529491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/261852
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=002dd32cd97ad8a77ee1e4d55d36320e1f4037e6
Submitter: Jenkins
Branch: master

commit 002dd32cd97ad8a77ee1e4d55d36320e1f4037e6
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 17:47:58 2015 +0000

    Minor clean-ups for gw device extension

    * Use constant that is already defined
    * Consistent indentation

    Change-Id: I8c8438f05f086ed1d68ecb7ddea79062779dd2e5
    Partial-Bug: #1529491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/261853
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=54b59956b31c3ab296f53377239585f5270e169a
Submitter: Jenkins
Branch: master

commit 54b59956b31c3ab296f53377239585f5270e169a
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 18:03:49 2015 +0000

    Minor clean-up for gateway device unit tests

    * Favor parenthesis over \ for line wrapping
    * _create_gateway_device_remote_mac_entry should accept gw_dev_id as a
     mandatory param
    * Fix indentation inconsistencies
    * Fix typos

    Change-Id: Ie4c69443f3c06b7e367d071e37a9d32b15e8d8d6
    Partial-Bug: #1529491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/261855
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=5e1b85246b7a53fe70da51e0b5f0bd13e459d024
Submitter: Jenkins
Branch: master

commit 5e1b85246b7a53fe70da51e0b5f0bd13e459d024
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 18:26:54 2015 +0000

    Remove tenant_id references from gw remote mac

    tenant_id was removed from gateway remove mac table.
    Remove all the references to it.

    Change-Id: I157aa2f325c63e9796b217b1874cac46cbecc32d
    Partial-Bug: #1529491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/261856
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=5a859571c906d260df3c6999b91d0255cc097bd2
Submitter: Jenkins
Branch: master

commit 5a859571c906d260df3c6999b91d0255cc097bd2
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 19:35:43 2015 +0000

    Remove incorrect primary key in GW Mac entry

    'device_id' is not a primary key for remote_mac_entries table.

    Change-Id: Ib5dfab1961144b2de58091020ff60767fc679190
    Partial-Bug: #1529491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/261861
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=e1109bd68dcc1534c5c092a1d81bf854eb558080
Submitter: Jenkins
Branch: master

commit e1109bd68dcc1534c5c092a1d81bf854eb558080
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 20:46:42 2015 +0000

    Remove manual check for duplicate GW remote mac

    Define DuplicateRemoteMacEntry to replace manual check of duplicate mac
    address/vtep address on remote mac entry creation.

    Change-Id: Ib326bf8a5f03f5ed3deb8ebc22dfec4aaad62fc8
    Partial-Bug: #1529491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/261862
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=76e774c7453999080e76df9a92c7f492132d0ad9
Submitter: Jenkins
Branch: master

commit 76e774c7453999080e76df9a92c7f492132d0ad9
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 21:20:09 2015 +0000

    Reverse param order for remote mac create method

    For consistency with other extensions, place the arg for the parent
    resource ID, gateway_device_id, before the child resource object,
    remote_mac_entry, in the create method.

    Change-Id: Idd1092573f6fe825023aa2850b0a0340b9568bf3
    Partial-Bug: #1529491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/261865
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=7c37b5a03af8037d9284bfa2d47c400c15db20e8
Submitter: Jenkins
Branch: master

commit 7c37b5a03af8037d9284bfa2d47c400c15db20e8
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 21:43:23 2015 +0000

    Remove _check_gateway_device_exists in GW DB mixin

    _check_gateway_device_exists is a duplicate of _get_gateway_device.

    Change-Id: Iec2500e022ff94408b0b0aae71d640e81ce19d70
    Partial-Bug: #1529491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/261866
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=11297a019d41a8f6ed00d6615824d6b88afd2cb6
Submitter: Jenkins
Branch: master

commit 11297a019d41a8f6ed00d6615824d6b88afd2cb6
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 21:52:22 2015 +0000

    Add method logging to remote mac entry methods

    Change-Id: I5e55ab59e7a3b001c9d0ba5bed7f989679a9df85
    Partial-Bug: #1529491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/261867
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=f7361b98cae061b0d8416dffe20c97b447178147
Submitter: Jenkins
Branch: master

commit f7361b98cae061b0d8416dffe20c97b447178147
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 21:58:32 2015 +0000

    Minor clean-ups of gw device plugin

    Change-Id: I5ccf75d6763be59f494ead77e8dbb3e6f516cba1
    Partial-Bug: #1529491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/261868
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=d9cd27eaa3f1c22f49619587cda33ef74b9ff021
Submitter: Jenkins
Branch: master

commit d9cd27eaa3f1c22f49619587cda33ef74b9ff021
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 22:30:04 2015 +0000

    Add post/precommit methods for remote mac entries

    MidoNet now handles remote mac creation and deletion as a top level
    resource. Adapt the plugin to match the MidoNet change.

    Change-Id: Id1fe176d42246166b6f064a7a514c9c4995bd99e
    Partial-Bug: #1529491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/261869
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=0df0582c8f1fea95c5b78c590308cebc7ac0f08d
Submitter: Jenkins
Branch: master

commit 0df0582c8f1fea95c5b78c590308cebc7ac0f08d
Author: Ryu Ishimoto <email address hidden>
Date: Sun Dec 27 22:36:39 2015 +0000

    Delete from DB only on remote mac create MN error

    For clean-up on MidoNet error when creating a remote mac entry, just
    delete from the Neutron DB.

    Change-Id: Ia9669fddcd55e0bd698d171af38a5650e53ab74b
    Partial-Bug: #1529491

Changed in networking-midonet:
status: In Progress → Fix Committed
Changed in networking-midonet:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.