VNC ports are blocked on compute nodes

[Sergey Kolekonov]

VNC ports should be open on compute nodes, as they need to be accessible from controller nodes. Currently they are opened on controllers: https://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/modular/firewall/firewall.pp#L221

ISO #344

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/262255

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/262255
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=bb44e7113fabc9791ae3b96fe716e537b12a0443
Submitter: Jenkins
Branch: master

commit bb44e7113fabc9791ae3b96fe716e537b12a0443
Author: Matthew Mosesohn <email address hidden>
Date: Tue Dec 29 16:32:42 2015 +0300

    Add nova vnc firewall rule for compute nodes

    Compute nodes need to open vnc to management net
    so novavncproxy can forward it.

    Change-Id: I18c15706ff1290638e26fb46291a6ac4276ad07d
    Closes-Bug: #1529112

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/265720

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/265720
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=fdcff93e398534f748f5818bb39368c3bd9130f1
Submitter: Jenkins
Branch: stable/8.0

commit fdcff93e398534f748f5818bb39368c3bd9130f1
Author: Matthew Mosesohn <email address hidden>
Date: Tue Dec 29 16:32:42 2015 +0300

    Add nova vnc firewall rule for compute nodes

    Compute nodes need to open vnc to management net
    so novavncproxy can forward it.

    Change-Id: I18c15706ff1290638e26fb46291a6ac4276ad07d
    Closes-Bug: #1529112
    (cherry picked from commit bb44e7113fabc9791ae3b96fe716e537b12a0443)

[Mikhail Samoylov (msamoylov)]

Steps:
1. Deploy cluster with 1 compute and 1 controller
2. Create virtual machine (instance) from horizon
3. Check that we have VNC access to our VM from horizon

Verified in fuel version:
cat /etc/fuel/version.yaml
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "506"
  build_id: "506"
  fuel-nailgun_sha: "8e954abd70ef0083109f34289de2553dcda544d4"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "ec7e212972ead554f21b52b9e165156665f659df"
  fuel-ostf_sha: "ab5fd151fc6c1aa0b35bc2023631b1f4836ecd61"
  fuel-mirror_sha: "351d568fa3b3e4dd062054b91d766aa54d379867"
  fuelmenu_sha: "234cb4cbb30fbd2df00f388c28f31606d9cae15f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "94507c5e4dad6d8cfbd8f5d41aa8389d5335990a"

[Vladimir (vushakov)]

Blocked by: https://bugs.launchpad.net/fuel/+bug/1566806
Fuel 9.0 ISO #157

[Mikhail Samoylov (msamoylov)]

Verified in fuel-9.0-mos-352