[Task Based] Deployment fails because of unnecessary validation

[Bulat Gaifullin]

The task-based-deployment engine contains logic that allows to fallback to granular deployment in case if not all tasks support the cross-node dependencies. This check runs for all tasks.
Need to modify this algorithm to exclude the tasks with type "stage", because they are artificial task, that cannot contain cross-dependency.
And need to exclude from check tasks that will not be included to deployment graph, because they do not affect deployment procedure.

Short summary:
The versions check must be disabled for tasks that are not be added to graph.
The versions check must be disabled for tasks with type "stage".

Cases:
Installation plugin that provides tasks with version less than 2.0.0 should not affect task base deployment in case if this plugin is not enabled for cluster.
The pre_deployment and post_deployment tasks, those are defined in nailgun, should not cause tailback to granular deploy and it is not needed to update version for this tasks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/261334

[Aleksey Kasatkin (alekseyk-ru)]

Bulat, please provide more information. It is not clear was is your case and how to validate the bug/fix.

[Bulat Gaifullin (bulat.gaifullin)]

Updated description.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/261334
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=b1be601da45a72e624b5da04ece8a75af29b2c7e
Submitter: Jenkins
Branch: master

commit b1be601da45a72e624b5da04ece8a75af29b2c7e
Author: Bulat Gaifullin <email address hidden>
Date: Thu Dec 24 17:23:57 2015 +0300

    Disabled unnecessary checks for version of tasks

    The versions check must be disabled for tasks that are not be added to graph.
    The versions check must be disabled for tasks with type "stage".

    Closes-Bug: #1529104
    Change-Id: I128176ba8860968f84eada8b75998734ae53165c

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/262451

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/262451
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=f5d62cbd7938073ac4aa2c114322645ca11fbe0e
Submitter: Jenkins
Branch: stable/8.0

commit f5d62cbd7938073ac4aa2c114322645ca11fbe0e
Author: Bulat Gaifullin <email address hidden>
Date: Thu Dec 24 17:23:57 2015 +0300

    Disabled unnecessary checks for version of tasks

    The versions check must be disabled for tasks that are not be added to graph.
    The versions check must be disabled for tasks with type "stage".

    Closes-Bug: #1529104
    Change-Id: I128176ba8860968f84eada8b75998734ae53165c
    (cherry picked from commit b1be601da45a72e624b5da04ece8a75af29b2c7e)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/280692

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/280692
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=637cbfa72bd870b7c45ca44cc5d4fd359600ed3d
Submitter: Jenkins
Branch: master

commit 637cbfa72bd870b7c45ca44cc5d4fd359600ed3d
Author: Alexandr Kostrikov <email address hidden>
Date: Tue Feb 16 16:27:15 2016 +0300

    Add corner cases to task tests

    To fully reflect bug description
    some additional checks are added.

    Change-Id: I7129a16a46c6a9f45cd03dfcb8ede62ee2838db0
    Related-bug: #1529104