[Ironic] fuel-agent doesn't install grub

Bug #1529066 reported by Vasyl Saienko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Alexander Gordeev

Bug Description

fuel-agent copy image to disk, but doesn't install grub.
As result server stuck in "Boot from hard disk"
There is fuel-agent logs:
https://paste.mirantis.net/show/1635/

Tags: area-python
Vasyl Saienko (vsaienko)
Changed in fuel:
assignee: nobody → Alexander Gordeev (a-gordeev)
Changed in fuel:
importance: Undecided → High
milestone: none → 8.0
status: New → Confirmed
tags: added: area-python
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/261562

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-agent (master)

Reviewed: https://review.openstack.org/261562
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=95fe335f2451703e68318787196a1ea4648f94e3
Submitter: Jenkins
Branch: master

commit 95fe335f2451703e68318787196a1ea4648f94e3
Author: Alexander Gordeev <email address hidden>
Date: Fri Dec 25 19:45:13 2015 +0300

    Place bootloader onto /boot partition-less disks

    Sometimes, there's no separate /boot fs image. Therefore,
    a bootloader should have been installed onto disk where
    rootfs image lands.

    It seems that Nailgun driver didn't support such cases and then
    an expection regarding missing /boot partition was thrown.

    That was totally wrong approach. Nailgun driver should work fine
    without /boot partition if there's no /boot image.

    In addition, this change removes ugly hacks from Ironic driver.
    Apparently Ironic driver explicitly sets self._boot_done and
    self._boot_partition_done flags to True, hence enables to bypass
    that exception. Since now, Nailgun can handle such a case, so
    there're no any needs to keep that hack in Ironic driver.

    Change-Id: I2d97fec7810643865abf0414f2cb80da1c591398
    Closes-Bug: #1529066

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-agent (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/262260

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-agent (stable/8.0)

Reviewed: https://review.openstack.org/262260
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=7531763e72e1226634e73138911b6ccd013d81cf
Submitter: Jenkins
Branch: stable/8.0

commit 7531763e72e1226634e73138911b6ccd013d81cf
Author: Alexander Gordeev <email address hidden>
Date: Fri Dec 25 19:45:13 2015 +0300

    Place bootloader onto /boot partition-less disks

    Sometimes, there's no separate /boot fs image. Therefore,
    a bootloader should have been installed onto disk where
    rootfs image lands.

    It seems that Nailgun driver didn't support such cases and then
    an expection regarding missing /boot partition was thrown.

    That was totally wrong approach. Nailgun driver should work fine
    without /boot partition if there's no /boot image.

    In addition, this change removes ugly hacks from Ironic driver.
    Apparently Ironic driver explicitly sets self._boot_done and
    self._boot_partition_done flags to True, hence enables to bypass
    that exception. Since now, Nailgun can handle such a case, so
    there're no any needs to keep that hack in Ironic driver.

    Change-Id: I2d97fec7810643865abf0414f2cb80da1c591398
    Closes-Bug: #1529066
    (cherry picked from commit 95fe335f2451703e68318787196a1ea4648f94e3)

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/fuel-agent (openstack-ci/fuel-8.0/liberty)

Fix proposed to branch: openstack-ci/fuel-8.0/liberty
Change author: Aleksandr Gordeev <email address hidden>
Review: https://review.fuel-infra.org/16190

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/fuel-agent (openstack-ci/fuel-8.0/liberty)

Change abandoned by Alexander Evseev <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/16190

tags: added: on-verification
Revision history for this message
Andrey Sledzinskiy (asledzinskiy) wrote :

verified on 8.0-506

Changed in fuel:
status: Fix Committed → Fix Released
tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.