[fwaas] Deployment failed after executing upload_core_repos task

[Sergey Kolekonov]

upload_core_repos task re-executes both pre-deployment and post-deployment tasks of installed plugins. When FWaaS plugin is installed along with VPNaaS plugin, pre-deployment task from VPNaaS plugin removes VPN agent resource from all controller nodes (it's connected with necessity to support cluster scaling and missing ability to replace monolith Neutron resources deployment task in fuel-library). So there was a temporary case during upload_core_repos task execution when there were no L3 agents at all in the cluster. So FWaaS failed to operate with L3 agent resource. To prevent this, in 7.0 VPN agent should be only disabled by pre-deployment task.
In 8.0 this problem will be solved using new mechanism which allows to replace tasks from fuel-library.

[Sergey Kolekonov (skolekonov)]

The issue was addressed as a part of these two patches:
https://review.openstack.org/#/c/257900/
https://review.openstack.org/#/c/257889/