Web Client: Available holds in patron account

[Terran McCanna]

Wish list: It would be more user friendly if the display of the number of holds in the patron account on was available / total rather than total / available like it is now. (see attachment)

[Kyle Huckins (khuckins)]

I've added a commit here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1528916-available-holds-in-patron-account

I switched the places of patron_stats().holds.ready and patron_stats().holds.total in the holds tab, as well as the side bar for consistency. In anticipation of a planned fix for https://bugs.launchpad.net/evergreen/+bug/1527770, I've also made use of spans using ng-bind, rather than {{ }}.

[Bill Erickson (berick)]

Any other opinions out there on the use of ng-bind over the traditional {{ }} notation? I'd be a little surprised if we solve bug #1527770 through ng-bind alone, so I'm not sure if this is helping or creating a confusing bit of inconsistency.

[Mike Rylander (mrylander)]

Bill, I agree. Unless ng-bind is the way you spell {{}} in ng2, I think we should use {{}}. IIRC, there is supposed to be a way to keep ngview from rendering until the controller is completely hooked up? (re the other bug...)

[Bill Erickson (berick)]

Confirmed ng2 continues to use {{ }}.

Kyle, I suggest we stick to the status quo of using {{ }} instead of ng-bind for consistency.

[Kyle Huckins (khuckins)]

Sounds good, I'll send up a fix to my commit to bring it back to the status quo, and make sure future commits stick to {{}}.

[Kyle Huckins (khuckins)]

Fix pushed up, same link as before will work get to it

[Bill Erickson (berick)]

Thanks, Kyle.

Added milestones.

[Kathy Lussier (klussier)]

Thank you Kyle! It looks good to me. Merged to master for inclusion in 2.12.

[Kathy Lussier (klussier)]

I just noticed the milestones for 2.10 and 2.11, so I've backported to those releases as well. I'm also adding Kyle to https://wiki.evergreen-ils.org/doku.php?id=contributing:contributors since I believe this is his first commit to the Evergreen project. Congrats!