Network transmormation fails if add-port action has no bridge parameter

[Kyrylo Galanov]

Puppet run throws exception.

puppet apply /etc/puppet/modules/osnailyfacter/modular/openstack-network/plugins/ml2.pp --debug: http://paste.openstack.org/show/482522/

This issue affects system test 'deploy_ceph_net_tmpl'.

Steps to reproduce:
 1. Setup Fuel master and boot 5 slaves
 2. Create cluster (HA) with Neutron VLAN/VXLAN/GRE
 3. Add 3 controller + ceph nodes
 4. Add 2 compute + ceph nodes
 5. Upload 'ceph' network template https://github.com/openstack/fuel-qa/blob/901a27e56656b49f3d43092ef922fccc25f7c50e/fuelweb_test/network_templates/ceph.yaml
 6. Create custom network groups basing on template endpoints assignments
 7. Run network verification
 8. Deploy cluster

Expected result: cluster is deployed and passes health checks

Actual: deployment fails, puppet task 'openstack-network/plugins/ml2.pp' returns error on the primary controller

--
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "326"
  build_id: "326"
  fuel-nailgun_sha: "ec25ae8df28e1f1d87da653c5aab2711dff729f6"
  python-fuelclient_sha: "7c7a756fb6a3d091851c060003a2965c67aa353d"
  fuel-agent_sha: "d354cbe61b055db848a15ce66fb7ae92178d2c0a"
  fuel-nailgun-agent_sha: "a33a58d378c117c0f509b0e7badc6f0910364154"
  astute_sha: "c56dfde2da034151a7e707b381c4cf9d213b4ba2"
  fuel-library_sha: "bcc3d042a47547f6ad826360a85ef21dcaf25882"
  fuel-ostf_sha: "b2ebf15a3530b5c7b57707acf8642c1c3ac71bd8"
  fuel-mirror_sha: "8100acb3a566358d0d4ecc66de32d39626263028"
  fuelmenu_sha: "2942a85796d37f09ba8c8c6d762d8813292cf0d4"
  shotgun_sha: "cacb93cbc28910ff0dc38f30a855efa9af50d8ce"
  network-checker_sha: "d443ef47abeda58d319bc8d33d5005dd09440a02"
  fuel-upgrade_sha: "718aa3d7021fee2970f0fa6791cf5188578cc516"
  fuelmain_sha: "3faa824728ce60734abe602ff3778976f8a16eed"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/260602

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/260602
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=f4b0df8a1e921581d1e4ef8fdeb269953cb82f44
Submitter: Jenkins
Branch: master

commit f4b0df8a1e921581d1e4ef8fdeb269953cb82f44
Author: Kyrylo Galanov <email address hidden>
Date: Tue Dec 22 17:27:25 2015 +0200

    Fix MTU generator failure without bridge parameter

    Fix function code to treat bridge parameter as optional.
    Plus fix typo.

    Change-Id: I202b7b7c43e13325b4fc87de0acf571df50f868f
    Closes-bug: #1528607

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/262187

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/262187
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=a0790addc1415e56da7550456347d47b0734008b
Submitter: Jenkins
Branch: stable/8.0

commit a0790addc1415e56da7550456347d47b0734008b
Author: Kyrylo Galanov <email address hidden>
Date: Tue Dec 22 17:27:25 2015 +0200

    Fix MTU generator failure without bridge parameter

    Fix function code to treat bridge parameter as optional.
    Plus fix typo.

    Change-Id: I202b7b7c43e13325b4fc87de0acf571df50f868f
    Closes-bug: #1528607

[Mikhail Samoylov (msamoylov)]

Verified. We have auto test for this scenario that was passed on CI job: https://product-ci.infra.mirantis.net/job/8.0.system_test.ubuntu.network_templates/135/testReport/%28root%29/deploy_ceph_net_tmpl/

[ElenaRossokhina (esolomina)]

verification is blocked: https://bugs.launchpad.net/fuel/+bug/1583629

[Mikhail Samoylov (msamoylov)]

Verified on CI (ISO 420):
https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.network_templates/126/testReport/%28root%29/deploy_ceph_net_tmpl/