Deploy failed on node with Compute, Storage - Cinder Block Device

[Oleksiy Butenko]

Steps to reproduce:
1) Create new environment
2) Add nodes with 1 - Controller, Storage - Cinder, 1 - Compute, Storage - Cinder Block Device. Neutron with VLAN.
     Additional Components: Sahara.

Result:

Deploy failed on node with Compute, Storage - Cinder Block Device.

Puppet log error:

Could not find data item public_vip in any Hiera data file and no default supplied at /etc/puppet/modules/osnailyfacter/modular/roles/cinder.pp:7 on node node-2.test.domain.local

[Oleksiy Butenko (obutenko)]

https://goo.gl/nYacDV - Diagnostic Snapshot

[Oleksiy Butenko (obutenko)]

Reproduced on env without Sahara and Storage - Cinder role:
1 - Controller, 1 - Compute, Storage - Cinder Block Device.

[Evgeny Sikachev (esikachev)]

On compute i see :
    root@node-2:~# hiera public_vip
    172.16.56.84

If run modular manual, we can see:
   Notice: Finished catalog run in 288.27 seconds

WORKAROUND: Restart deployment (without reset)

[Oleksiy Butenko (obutenko)]

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "328"
  build_id: "328"
  fuel-nailgun_sha: "ec25ae8df28e1f1d87da653c5aab2711dff729f6"
  python-fuelclient_sha: "7c7a756fb6a3d091851c060003a2965c67aa353d"
  fuel-agent_sha: "d354cbe61b055db848a15ce66fb7ae92178d2c0a"
  fuel-nailgun-agent_sha: "a33a58d378c117c0f509b0e7badc6f0910364154"
  astute_sha: "c56dfde2da034151a7e707b381c4cf9d213b4ba2"
  fuel-library_sha: "bcc3d042a47547f6ad826360a85ef21dcaf25882"
  fuel-ostf_sha: "b2ebf15a3530b5c7b57707acf8642c1c3ac71bd8"
  fuel-mirror_sha: "8100acb3a566358d0d4ecc66de32d39626263028"
  fuelmenu_sha: "2942a85796d37f09ba8c8c6d762d8813292cf0d4"
  shotgun_sha: "cacb93cbc28910ff0dc38f30a855efa9af50d8ce"
  network-checker_sha: "d443ef47abeda58d319bc8d33d5005dd09440a02"
  fuel-upgrade_sha: "718aa3d7021fee2970f0fa6791cf5188578cc516"
  fuelmain_sha: "3faa824728ce60734abe602ff3778976f8a16eed"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/261499

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/262040

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/261499
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=67215c22fe4ccb09b9847260c6dfdcb4870fa77b
Submitter: Jenkins
Branch: master

commit 67215c22fe4ccb09b9847260c6dfdcb4870fa77b
Author: Matthew Mosesohn <email address hidden>
Date: Fri Dec 25 14:58:15 2015 +0300

    Fix dependencies for cinder-block-device role

    Hiera and globals are needed to run cinder task.
    Additionally, fixed the role dependency for
    cinder-block-device, because it requires the node config
    to be done by compute role first.

    Change-Id: I01efd03e649157389ac3bdac1103c3207216bd25
    Closes-Bug: #1528502

[Evgeny Sikachev (esikachev)]

fix for 8.0 is still on review that's why status was changed from "Fix Committed" to "In Progress", fix for master branch was already merged, so I added 9.0 milestone to track that.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/262040
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=7d1598b3c063fd5add90f090d7e4b629cd8375a4
Submitter: Jenkins
Branch: stable/8.0

commit 7d1598b3c063fd5add90f090d7e4b629cd8375a4
Author: Matthew Mosesohn <email address hidden>
Date: Fri Dec 25 14:58:15 2015 +0300

    Fix dependencies for cinder-block-device role

    Hiera and globals are needed to run cinder task.
    Additionally, fixed the role dependency for
    cinder-block-device, because it requires the node config
    to be done by compute role first.

    Change-Id: I01efd03e649157389ac3bdac1103c3207216bd25
    Closes-Bug: #1528502

[Dmitriy Kruglov (dkruglov)]

Verified on MOS 8.0, build 405. The issue is fixed.

ISO details:
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "405"
  build_id: "405"
  fuel-nailgun_sha: "9ebbaa0473effafa5adee40270da96acf9c7d58a"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "df16d41cd7a9445cf82ad9fd8f0d53824711fcd8"
  fuel-nailgun-agent_sha: "92ebd5ade6fab60897761bfa084aefc320bff246"
  astute_sha: "c7ca63a49216744e0bfdfff5cb527556aad2e2a5"
  fuel-library_sha: "037ca95820aac8214fe65e7e0461074e1cf6891c"
  fuel-ostf_sha: "214e794835acc7aa0c1c5de936e93696a90bb57a"
  fuel-mirror_sha: "8bb8c70efc61bcf633e02d6054dbf5ec8dcf6699"
  fuelmenu_sha: "2a0def56276f0fc30fd949605eeefc43e5d7cc6c"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "62573cb2a8aa54845de9303b4a30935a90e1db61"

[ElenaRossokhina (esolomina)]

Verification is blocked by https://bugs.launchpad.net/fuel/+bug/1561380

[ElenaRossokhina (esolomina)]

Verified on fuel-9.0-106-2016-03-24_02-00-00.iso using scenario from #2