fuel menu does not save settings for network setup

[Kevin Nguyen]

After deploy fuel 8 , launch fuelmenu from command line and try to change network setup.
Symptom: Click 'apply' does not save settings.

-------------------
If puppet apply of l23netowrk changes fails, fuelmenu doesn't report an error.
If you unset the gateway of an interface, the right settings are saved, but the system gateway is not unset.

[Maciej Relewicz (rlu)]

Hi, thank you for your report, but please provide diagnostic snapshot from the failed environment if it is possible.

[Kevin Nguyen (huykevin)]

Attach screenshot on fuelmenu with modify 'IP address' and 'Default Gateway'. Click 'Apply' button will take a while ( > 20 s) and old new value does not resist.

Old value IP address : 10.20.0.2
New value IP address: 10.22.0.2

Please see attach screenshot. From screenshot, above pic is screenshot before modify network setup, below pic is screenshot with network setup modify. After click Apply, fuel menu return back 1st pic screenshot.

Thanks.

[Matthew Mosesohn (raytrac3r)]

There must be some errors in the puppet log. We use l23network puppet module to apply network changes, but without the logs, I don't know what went wrong. Can you attach a copy of /var/log/ from your fuel master node? Thanks!

[Kevin Nguyen (huykevin)]

Hi Matthew,

I am not able to configure network for Fuel and not able to ssh for get log file. ssh is disable in MOS 8 by default? how to enable it.
Please see follow attachment for more details how I deploy fuel 8.0 (fuel-8.0-295-2015-12-15_01-42-00.iso) on vSphere 6 Test grid.

Thanks.
Kevin

[Kevin Nguyen (huykevin)]

Thanks Andrey for help collect log file

/var/log/puppet
/var/log/fuelmenu.log
/var/log/docker-logs

[Matthew Mosesohn (raytrac3r)]

Kevin, I've discussed with Andrey about your issue. It seems that on Dec 17 the Puppet bug for networking was fixed here:
https://review.openstack.org/#/c/258597/

There are 3 remaining issues in your environment:
* Fuelmenu doesn't report errors in applying changes to network (false positive)
* Fuelmenu doesn't unset the gateway correctly if you remove the gateway from an interface. It writes the configuration, but doesn't explicitly unset.
* Something caused rabbitmq to crash

#3 I'm not so sure of, but we should get network settings correct before we can debug RabbitMQ further.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/262567

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/262567
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=1e05564a8cb6be167cceddac31449f133da0e096
Submitter: Jenkins
Branch: master

commit 1e05564a8cb6be167cceddac31449f133da0e096
Author: Matthew Mosesohn <email address hidden>
Date: Wed Dec 30 19:52:46 2015 +0300

    Fix failed puppet run and gateway unset

    Failed puppet runs now properly cause an error in the UI.

    Unsetting gateway when it is the default gateway now
    unsets the gateway for the host.

    Change-Id: I1a281da1632ab7ef7ff9274f61933d773634b15c
    Partial-Bug: #1528437

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/266966

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/266966
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=964f066c4ee830648a10c91fb8d3824c51bb5e8f
Submitter: Jenkins
Branch: stable/8.0

commit 964f066c4ee830648a10c91fb8d3824c51bb5e8f
Author: Matthew Mosesohn <email address hidden>
Date: Wed Dec 30 19:52:46 2015 +0300

    Fix failed puppet run and gateway unset

    Failed puppet runs now properly cause an error in the UI.

    Unsetting gateway when it is the default gateway now
    unsets the gateway for the host.

    Change-Id: I1a281da1632ab7ef7ff9274f61933d773634b15c
    Partial-Bug: #1528437
    (cherry picked from commit 1e05564a8cb6be167cceddac31449f133da0e096)

[Dmitry Belyaninov (dbelyaninov)]

Verified on ISO #525

Scenario from comment #2 is reproducible, there are no any other errors.

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "525"
  build_id: "525"
  fuel-nailgun_sha: "baec8643ca624e52b37873f2dbd511c135d236d9"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "f2ed8e4503dd9641b70b94381d30e21689b8e5c9"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "e071216cb214e34b4d861478033425ee6a54a3be"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "a365f05b903368225da3fea9aa42afc1d50dc9b4"

[Pavel Chechetin (paulche)]

I run into the same issue with RC1 (#529).
Change below resolves it.
https://review.openstack.org/276748

[ElenaRossokhina (esolomina)]

Verified on iso #324
cat /etc/fuel_build_id:
 324
cat /etc/fuel_build_number:
 324
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6344.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8682.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-mirror-9.0.0-1.mos135.noarch
 fuel-openstack-metadata-9.0.0-1.mos8682.noarch
 fuel-notify-9.0.0-1.mos8356.noarch
 fuel-ostf-9.0.0-1.mos934.noarch
 python-fuelclient-9.0.0-1.mos314.noarch
 fuelmenu-9.0.0-1.mos270.noarch
 fuel-9.0.0-1.mos6344.noarch
 fuel-utils-9.0.0-1.mos8356.noarch
 fuel-nailgun-9.0.0-1.mos8682.noarch
 rubygem-astute-9.0.0-1.mos742.noarch
 fuel-library9.0-9.0.0-1.mos8356.noarch
 shotgun-9.0.0-1.mos88.noarch
 fuel-agent-9.0.0-1.mos276.noarch
 fuel-ui-9.0.0-1.mos2682.noarch
 fuel-setup-9.0.0-1.mos6344.noarch
 nailgun-mcagents-9.0.0-1.mos742.noarch
 fuel-misc-9.0.0-1.mos8356.noarch
 python-packetary-9.0.0-1.mos135.noarch
 fuel-bootstrap-cli-9.0.0-1.mos276.noarch
 fuel-migrate-9.0.0-1.mos8356.noarch