Response from nailgun not presented on UI

[Anastasia Palkina]

This issue related to https://bugs.launchpad.net/fuel/+bug/1519266

When I try to delete 2 node network groups one after another, server error appears (see screen)
But user should see clear text with error from firebug.

Bug has "High" status because it should be fixed in 8.0 release

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "327"
  build_id: "327"
  fuel-nailgun_sha: "ec25ae8df28e1f1d87da653c5aab2711dff729f6"
  python-fuelclient_sha: "7c7a756fb6a3d091851c060003a2965c67aa353d"
  fuel-agent_sha: "d354cbe61b055db848a15ce66fb7ae92178d2c0a"
  fuel-nailgun-agent_sha: "a33a58d378c117c0f509b0e7badc6f0910364154"
  astute_sha: "c56dfde2da034151a7e707b381c4cf9d213b4ba2"
  fuel-library_sha: "bcc3d042a47547f6ad826360a85ef21dcaf25882"
  fuel-ostf_sha: "b2ebf15a3530b5c7b57707acf8642c1c3ac71bd8"
  fuel-mirror_sha: "8100acb3a566358d0d4ecc66de32d39626263028"
  fuelmenu_sha: "2942a85796d37f09ba8c8c6d762d8813292cf0d4"
  shotgun_sha: "cacb93cbc28910ff0dc38f30a855efa9af50d8ce"
  network-checker_sha: "d443ef47abeda58d319bc8d33d5005dd09440a02"
  fuel-upgrade_sha: "718aa3d7021fee2970f0fa6791cf5188578cc516"
  fuelmain_sha: "3faa824728ce60734abe602ff3778976f8a16eed"

[Aleksandr Didenko (adidenko)]

Forwarding to UI team. Can we show a full error message on UI, just like we do in CLI?

409 Client Error: Conflict (A task is already running)

[Julia Aranovich (jkirnosova)]

Aleksandr, the issue should be fixed in Nailgun code.
The problem is that Nailgun returns plain text response in the case. But UI expects to get json in response with the following format: {message: <original_text>}.

UI handles json response only because it can be an arbitrary string in plain text response, for example it can be traceback and UI should not display it.

I also would not say that this issue is related to some another ticket, because I guess there are many places where Nailgun returns plain text response.

[Vitaly Kramskikh (vkramskikh)]

I'd say in the most of the handlers errors are returned in the correct (JSON-based) format. I don't remember any other handlers which return plain text

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/262041

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/262041
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4a7d97fa0a68c854f972cf90c86170628f007de9
Submitter: Jenkins
Branch: master

commit 4a7d97fa0a68c854f972cf90c86170628f007de9
Author: Aleksey Kasatkin <email address hidden>
Date: Mon Dec 28 19:06:44 2015 +0200

    Use content decorator for NodeGroupHandler.DELETE

    Change-Id: I38b0624d06b078ffeefcad5c8a4142bb4bd37103
    Closes-Bug: #1528264

[Anastasia Palkina (apalkina)]

Reproduced on ISO #417

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "417"
  build_id: "417"
  fuel-nailgun_sha: "9ebbaa0473effafa5adee40270da96acf9c7d58a"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "df16d41cd7a9445cf82ad9fd8f0d53824711fcd8"
  fuel-nailgun-agent_sha: "92ebd5ade6fab60897761bfa084aefc320bff246"
  astute_sha: "c7ca63a49216744e0bfdfff5cb527556aad2e2a5"
  fuel-library_sha: "7ef751bdc0e4601310e85b8bf713a62ed4aee305"
  fuel-ostf_sha: "214e794835acc7aa0c1c5de936e93696a90bb57a"
  fuel-mirror_sha: "b62f3cce5321fd570c6589bc2684eab994c3f3f2"
  fuelmenu_sha: "2a0def56276f0fc30fd949605eeefc43e5d7cc6c"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "cfeadd34d8d048deeabf0884931708b1d040b8a6"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/269716

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/269716
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=681449d71b39088bfb67d1f996c5f3a4f89b8576
Submitter: Jenkins
Branch: stable/8.0

commit 681449d71b39088bfb67d1f996c5f3a4f89b8576
Author: Aleksey Kasatkin <email address hidden>
Date: Mon Dec 28 19:06:44 2015 +0200

    Use content decorator for NodeGroupHandler.DELETE

    Change-Id: I38b0624d06b078ffeefcad5c8a4142bb4bd37103
    Closes-Bug: #1528264
    (cherry picked from commit 4a7d97fa0a68c854f972cf90c86170628f007de9)

[Veronica Krayneva (vkrayneva)]

Verified on #478 iso.

[Grigory Mikhailov (gmikhailov)]

Verified on #fuel-9.0-mos-402 iso.
Error message: "update_dnsmasq task is not finished after the previous configuration change. Please try again after a few seconds" is observed correctly.

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id: 402
cat /etc/fuel_build_number: 402
cat /etc/fuel_release: 9.0
cat /etc/fuel_openstack_version: mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6347.noarch
 fuel-bootstrap-cli-9.0.0-1.mos283.noarch
 fuel-migrate-9.0.0-1.mos8391.noarch
 rubygem-astute-9.0.0-1.mos746.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8709.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-mirror-9.0.0-1.mos136.noarch
 fuel-openstack-metadata-9.0.0-1.mos8709.noarch
 fuel-notify-9.0.0-1.mos8391.noarch
 nailgun-mcagents-9.0.0-1.mos746.noarch
 python-fuelclient-9.0.0-1.mos316.noarch
 fuelmenu-9.0.0-1.mos270.noarch
 fuel-9.0.0-1.mos6347.noarch
 fuel-utils-9.0.0-1.mos8391.noarch
 fuel-setup-9.0.0-1.mos6347.noarch
 fuel-library9.0-9.0.0-1.mos8391.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-agent-9.0.0-1.mos283.noarch
 fuel-ui-9.0.0-1.mos2702.noarch
 fuel-ostf-9.0.0-1.mos934.noarch
 fuel-misc-9.0.0-1.mos8391.noarch
 python-packetary-9.0.0-1.mos136.noarch
 fuel-nailgun-9.0.0-1.mos8709.noarch