Fuel for OpenStack

Fix hardcoded http URLs according to selective SSL blueprint

Bug #1528222 reported by Aleksandr Didenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Stanislaw Bogatkin
Fuel for OpenStack 9.0
8.0.x
Fix Released
High
Aleksandr Didenko
Fuel for OpenStack 8.0

Bug Description

To make selective SSL work properly we need to find and fix hardcoded http:// URLs like these:

https://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/modular/keystone/keystone.pp#L74-L75

Unfortunately there are no easy to reproduce steps, such functionality is implemented in fuel-library only in 8.0

Stanislaw Bogatkin (sbogatkin)
Changed in fuel:
status: New → Confirmed
Revision history for this message
Aleksandr Didenko (adidenko) wrote :

Another one
https://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/modular/horizon/horizon.pp#L21

Matthew Mosesohn (raytrac3r)
tags: added: team-bugfix
Matthew Mosesohn (raytrac3r)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/262174

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/262174
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=9d11e9c6567638282813982888c070c39bde6e9e
Submitter: Jenkins
Branch: master

commit 9d11e9c6567638282813982888c070c39bde6e9e
Author: Stanislaw Bogatkin <email address hidden>
Date: Tue Dec 29 12:37:00 2015 +0300

    Fix hardcoded urls for selective SSL implementation

    Remove hardcoded urls from modules. Also fix wrong url calls which could lead
    to use http instead of https.

    Closes-Bug: 1528222
    related blueprint: selective-ssl

    Change-Id: I28c437151699371f8e8a343aa1090d8e3a6de80f

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/263310

Aleksandr Didenko (adidenko)
Changed in fuel:
milestone: 8.0 → 9.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/265142

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/261352
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=180ddb9211544c887c00cec401506d4dc70f0d05
Submitter: Jenkins
Branch: master

commit 180ddb9211544c887c00cec401506d4dc70f0d05
Author: vsaienko <email address hidden>
Date: Thu Dec 24 17:43:57 2015 +0200

    Fix hardcoded urls for selective SSL implementation

    Remove hardcoded urls from Ironic upload_images task.

    Closes-Bug: 1528222
    Related to blueprint selective-ssl
    Change-Id: I492a90d4e2415ad35e1abae43c3b7ebf69879268

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/8.0)

Reviewed: https://review.openstack.org/263310
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=c27f2b22fe487f107aa7488d95a8a4266b6163c1
Submitter: Jenkins
Branch: stable/8.0

commit c27f2b22fe487f107aa7488d95a8a4266b6163c1
Author: Stanislaw Bogatkin <email address hidden>
Date: Tue Dec 29 12:37:00 2015 +0300

    Fix hardcoded urls for selective SSL implementation

    Remove hardcoded urls from modules. Also fix wrong url calls which could lead
    to use http instead of https.

    Closes-Bug: 1528222
    related blueprint: selective-ssl

    Change-Id: I28c437151699371f8e8a343aa1090d8e3a6de80f
    (cherry picked from commit 9d11e9c6567638282813982888c070c39bde6e9e)

Matthew Mosesohn (raytrac3r)
tags: added: team-network
removed: team-bugfix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/265142
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=bd81353b22b757254203a61dfccea52467419824
Submitter: Jenkins
Branch: stable/8.0

commit bd81353b22b757254203a61dfccea52467419824
Author: vsaienko <email address hidden>
Date: Thu Dec 24 17:43:57 2015 +0200

    Fix hardcoded urls for selective SSL implementation

    Remove hardcoded urls from Ironic upload_images task.

    Closes-Bug: 1528222
    Related to blueprint selective-ssl
    Change-Id: I492a90d4e2415ad35e1abae43c3b7ebf69879268

Mikhail Samoylov (msamoylov)
tags: added: on-verification
Revision history for this message
Mikhail Samoylov (msamoylov) wrote :

Verified by code review.

tags: removed: on-verification
Changed in fuel:
status: Fix Committed → Fix Released
status: Fix Released → Fix Committed
Mikhail Samoylov (msamoylov)
tags: added: on-verification
Revision history for this message
Mikhail Samoylov (msamoylov) wrote :

Checked in 483 ISO
Steps
1. Deploy master
2. Check that we haven't http for public services in puppet manifests
grep -r -i 'http://' --include=\*.pp --exclude-dir=/etc/puppet/modules/fuel/ /etc/puppet/modules/

Actual result:
No http proto for public services

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.