[contrail] Deploy cluster failed on ntp-server.pp with Contrail plugin 3.0

[Iryna Vovk]

Steps to reproduce:

            1. Create an environment with "Neutron with tunneling segmentation" as a network configuration
            2. Enable and configure Contrail plugin
            3. Add a node with controller role
            4. Add 2 nodes with "compute" and "Storage-cinder" roles
            5. Add a node with Base-OS role
            6. Add 3 nodes with "contrail-config", "contrail-control" and "contrail-db" roles
            7. Deploy cluster with plugin

Expected result:
Deploy cluster passed successfully

Actual result:
[689] Error running RPC method granular_deploy: Failed to execute hook 'puppet' Puppet run failed. Check puppet logs for details --- priority: 900 fail_on_error: true type: puppet uids: - '1' parameters: puppet_modules: "/etc/puppet/modules"

puppet_manifest: "/etc/puppet/modules/osnailyfacter/modular/ntp/ntp-server.pp"
timeout: 3600

 cwd: "/" , trace: ["/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/nailgun_hooks.rb:59:in `block in process'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/nailgun_hooks.rb:26:in `each'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/nailgun_hooks.rb:26:in `process'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/deployment_engine/granular_deployment.rb:221:in `post_deployment_actions'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/deployment_engine.rb:75:in `deploy'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/orchestrator.rb:179:in `deploy_cluster'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/orchestrator.rb:45:in `granular_deploy'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/server/dispatcher.rb:91:in `granular_deploy'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/server/server.rb:146:in `dispatch_message'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/server/server.rb:107:in `block in dispatch'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/server/task_queue.rb:64:in `call'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/server/task_queue.rb:64:in `block in each'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/server/task_queue.rb:56:in `each'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/server/task_queue.rb:56:in `each'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/server/server.rb:105:in `each_with_index'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/server/server.rb:105:in `dispatch'", "/usr/lib64/ruby/gems/2.1.0/gems/astute-7.0.0/lib/astute/server/server.rb:89:in `block in perform_main_job'"]

additional info:
this is juniper distribution
api: '1.0'
astute_sha: 6c5b73f93e24cc781c809db9159927655ced5012
auth_required: true
build_id: '301'
build_number: '301'
feature_groups:
- mirantis
fuel-agent_sha: 50e90af6e3d560e9085ff71d2950cfbcca91af67
fuel-library_sha: 5d50055aeca1dd0dc53b43825dc4c8f7780be9dd
fuel-nailgun-agent_sha: d7027952870a35db8dc52f185bb1158cdd3d1ebd
fuel-ostf_sha: 2cd967dccd66cfc3a0abd6af9f31e5b4d150a11c
fuelmain_sha: a65d453215edb0284a2e4761be7a156bb5627677
nailgun_sha: 4162b0c15adb425b37608c787944d1983f543aa8
openstack_version: 2015.1.0-7.0
production: docker
python-fuelclient_sha: 486bde57cda1badb68f915f66c61b544108606f3
release: '7.0'
release_versions:
  2015.1.0-7.0:
    VERSION:
      api: '1.0'
      astute_sha: 6c5b73f93e24cc781c809db9159927655ced5012
      build_id: '301'
      build_number: '301'
      feature_groups:
      - mirantis
      fuel-agent_sha: 50e90af6e3d560e9085ff71d2950cfbcca91af67
      fuel-library_sha: 5d50055aeca1dd0dc53b43825dc4c8f7780be9dd
      fuel-nailgun-agent_sha: d7027952870a35db8dc52f185bb1158cdd3d1ebd
      fuel-ostf_sha: 2cd967dccd66cfc3a0abd6af9f31e5b4d150a11c
      fuelmain_sha: a65d453215edb0284a2e4761be7a156bb5627677
      nailgun_sha: 4162b0c15adb425b37608c787944d1983f543aa8
      openstack_version: 2015.1.0-7.0
      production: docker
      python-fuelclient_sha: 486bde57cda1badb68f915f66c61b544108606f3
      release: '7.0'

[Oleksandr Martsyniuk (omartsyniuk)]

From puppet logs:

2015-12-17 18:24:26 +0000 Cs_resource[p_ntp](provider=crm) (debug): trying to delete old shadow if exists
2015-12-17 18:24:26 +0000 Puppet (debug): Executing '/usr/sbin/crm_shadow -b -f -D resource_p_ntp'
2015-12-17 18:24:26 +0000 Puppet (debug): Executing '/usr/sbin/crm_shadow -b -c resource_p_ntp'
2015-12-17 18:24:28 +0000 Puppet::Type::Cs_resource::ProviderCrm (debug): Command '/usr/sbin/crm configure load update /tmp/puppet_crm_update20151217-15327-1n3rcvj' failed, and return RC=1, output:
2015-12-17 18:24:28 +0000 Puppet::Type::Cs_resource::ProviderCrm (debug): error: unpack_location_tags: Constraint 'cli-ban-p_neutron-dhcp-agent-on-node-1.test.domain.local': Invalid reference to 'p_neutron-dhcp-agent'
2015-12-17 18:24:28 +0000 Puppet::Type::Cs_resource::ProviderCrm (debug): error: unpack_location_tags: Constraint 'cli-ban-p_neutron-l3-agent-on-node-1.test.domain.local': Invalid reference to 'p_neutron-l3-agent'
2015-12-17 18:24:28 +0000 Puppet::Type::Cs_resource::ProviderCrm (debug): error: unpack_location_tags: Constraint 'cli-ban-p_neutron-metadata-agent-on-node-1.test.domain.local': Invalid reference to 'p_neutron-metadata-age
nt'
2015-12-17 18:24:28 +0000 Puppet::Type::Cs_resource::ProviderCrm (debug): error: unpack_location_tags: Constraint 'cli-ban-p_neutron-plugin-openvswitch-agent-on-node-1.test.domain.local': Invalid reference to 'p_neutron-pl
ugin-openvswitch-agent'
2015-12-17 18:24:28 +0000 Puppet::Type::Cs_resource::ProviderCrm (debug): Errors found during check: config not valid
2015-12-17 18:24:28 +0000 Puppet::Type::Cs_resource::ProviderCrm (debug): WARNING: p_ntp: specified timeout 10 for monitor is smaller than the advised 20s
2015-12-17 18:24:28 +0000 Cs_resource[p_ntp](provider=crm) (debug): no difference - nothing to apply

Looks like disabling resources affects adding new ones.
After deleting the mentioned resources ntp-server task works fine.