Some buildings have lost build animations; Add check for lua tables

[kaputtnik]

bzr 7671

During game play i saw that empire arena has no build animation anymore. Normally this building has 4 images when it will be build. See attachment. Currently only "build_00.png" is used. I checked the corresponding init.lua file and found that the "build" table has an entry "fps = 1" See http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/tribes/buildings/trainingsites/empire/arena/init.lua#L34

Removing this "fps" entry will let the other build images appear during game play. I checked some of the other files and found several "fps = 1 " entries in the build table for buildings:

barbarians_trainingcamp
barbarians_battlearena
barbarians_port
barbarians_warehouse
empire_port
atlanteans_port

I tested barbarians warehouse and it has also no building animation during game play. So i think the "fps = 1" property is wrong in the build table of the lua files.

May there should be a check for valid properties in each table of lua files to prevent such failures?

If some one could verify that "fps = 1" is wrong in the build table, i will make a branch containing fixed lua files.

[GunChleoc (gunchleoc)]

This was probably caused by the one_tribe change - I did a lot of copy/paste there.

The only checks for FPS that we have in the code is that animations with only 1 frame aren't allowed to define any FPS.

Maybe you could compare with the old conf files, e.g. by looking at the code fom Build 18.

[kaputtnik (franku)]

Branch added which fix the build animation.

If you don't think a check for the table is needed, i will propose it for merge.

[GunChleoc (gunchleoc)]

I think a check would be too specific - this isn't likely to happen when new animations get added. Please propose a merge.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.