Task execution is not created if task inputs are invalid

[Moshe Elisha]

When task inputs are incorrect - no task execution is created for that task.

I believe that the correct behaviour should be that there is a task execution for the failed task - and the state should be ERROR and the state info should contain the reason.

---
version: '2.0'

test_next_task_inputs_error:
  tasks:
    task_one:
      action: std.noop
      on-success:
        - task_two

    task_two:
      action: std.echo message='<% $.non_existing_function_AAA() %>'

mistral task-list

+--------------------------------------+----------+-----------------------------+--------------------------------------+---------+------------+
| ID | Name | Workflow name | Execution ID | State | State info |
+--------------------------------------+----------+-----------------------------+--------------------------------------+---------+------------+
| bcf27629-8005-4b8e-bab4-0fa9d68198f1 | task_one | test_next_task_inputs_error | 78c8be6f-946c-4c4b-add7-bb25cf1f38a2 | SUCCESS | None |
+--------------------------------------+----------+-----------------------------+--------------------------------------+---------+------------+

mistral execution-list
+--------------------------------------+--------------------------------+-------------+---------+------------------------------+---------------------+---------------------+
| ID | Workflow | Description | State | State info | Created at | Updated at |
+--------------------------------------+--------------------------------+-------------+---------+------------------------------+---------------------+---------------------+
| 78c8be6f-946c-4c4b-add7-bb25cf1f38a2 | test_next_task_inputs_error | | ERROR | Can not evaluate YAQL exp... | 2015-12-17 09:51:19 | 2015-12-17 09:51:21 |
+--------------------------------------+--------------------------------+-------------+---------+------------------------------+---------------------+---------------------+

[Dmitri Zimine (i-dz)]

+1 for 'create task execution is a correct behavior'
recently a similar but had been fixed on execution. Let's do same for tasks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/400112

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/400112
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=9ddc32e9f78c1511fd47f58b5cb293264a00ac96
Submitter: Jenkins
Branch: master

commit 9ddc32e9f78c1511fd47f58b5cb293264a00ac96
Author: Renat Akhmerov <email address hidden>
Date: Mon Nov 21 15:35:45 2016 +0700

    Add a test for invalid task input expression

    * In fact, the bug does not exist. This patch only add a test
      to validate that the behavior in case of invalid task
      input

    Change-Id: If5dd3486114bf03ec98c251070e8613d1acee8ce
    Closes-Bug: 1527173

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/mistral 4.0.0.0b2 development milestone.