Editor crashes when changing tribe

Bug #1526903 reported by kaputtnik
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Unassigned

Bug Description

Steps to reproduce:

1. Create a new map or just open editor
2. Set a starting position of one or two players
3. Save the map
4. Load the map (either restart editor or just reopen the previous saved map)
5. change the tribe of player_1 or player_2
6. Save the map
7. Load the map again (either restart editor or just reopen the previous saved map)

Result:
Game data error
allowed buildings: player 1 (empire): tribe empire does not define building type "barbarians_headquarters"

Tags: crash editor

Related branches

Revision history for this message
TiborB (tiborb95) wrote :

Well, a workaround is to edit wmf (zip archive), and manually remove the file allowed_building_types

I looked at the code, and it seems there is no 'API' to remove unwanted profile (i.e. this file in this case)

So least "fix" would be to insert text to error popup saying what is needed to do.

Or generally we must consider if creating allowed_building_types when saving map in editor is needed at all

Revision history for this message
GunChleoc (gunchleoc) wrote :

Map loading generally needs fixing - cf. the discussion in this merge request: https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/276088

Changed in widelands:
milestone: none → build19-rc1
importance: Undecided → High
tags: added: crash editor
Revision history for this message
TiborB (tiborb95) wrote :

I dont think importance is high, there is handful of peoples creating maps and there is a workaround

Revision history for this message
TiborB (tiborb95) wrote :

Fixed in trunk 7690

Changed in widelands:
status: New → Fix Committed
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.