[librarary][idempotency] dump_rabbitmq_definitions.pp has non-idempotent execs

[Roman Sokolkov]

Environment:
- MOS 8.0 (fuel-8.0-284-2015-12-10_19-42-00.iso)

Steps to reproduce:
1) execute following command on deployed controller
root@node-1:~/lcm# puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/astute/dump_rabbitmq_definitions.pp
Notice: Scope(Class[main]): MODULAR: dump_rabbitmq_definitions.pp
Notice: Compiled catalog for node-1.domain.tld in environment production in 0.22 seconds
Notice: /Stage[main]/Main/Exec[rabbitmq-dump-definitions]/returns: current_value notrun, should be 0 (noop)
Notice: /Stage[main]/Main/Exec[rabbitmq-dump-clean]/returns: current_value notrun, should be 0 (noop)
Notice: Class[Main]: Would have triggered 'refresh' from 2 events
Notice: Stage[main]: Would have triggered 'refresh' from 1 events
Notice: Finished catalog run in 0.97 seconds

Expected result:
No changes

Actual result:
2 changes

[Alex Schultz (alex-schultz)]

This task probably shouldn't be idempotent as it's a task to backup the current rabbitmq definitions for restoration on failover. This exec should run everytime to collect the current definitions.

[Bartłomiej Piotrowski (bpiotrowski)]

Yeah, let's move it to Invalid.