Cannot disable password reset in TPAC

[Dan Wells]

Evergreen 2.8+

We expect Boolean options in config.tt2 to be 'true' or 'false', but the code is simple asking 'IF reset_password', which is true for either value. Instead, match on the string (as we do in other places). Branch is incoming!

[Dan Wells (dbw2)]

Branch at:

working/user/dbwells/lp1526543_reset_password_disable

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbwells/lp1526543_reset_password_disable

To test:
- Load the stock catalog login page
- Notice the "Forgot your password?" link, despite the default config being 'false'
- Apply patch, leaving 'reset_password' value in config.tt2 as 'false'
- RESULT: Password reset link doesn't show up

Also, I hereby declare this unworthy of automated testing! (super simple + no existing test framework (that I know of))

[Ben Shum (bshum)]

The actual default behavior is that the config.tt2 setting for 'reset_password' = true. So one has to set the value to false and then test the application of the patch.

Having done that, it looks good, so I'm pushing it to master with backports to rel_2_9 and rel_2_8.

Thanks Dan and Remington!