It's hard to distinguish multiple security-groups with the same name

Bug #1526238 reported by John Schwarz
16
This bug affects 4 people
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Wishlist
Unassigned

Bug Description

As the title says, when an admin prints all the security groups and if more than one security group has the same name, it's hard to distinguish the two. See [1] for an example. A (possibly) simple fix would be to add the 'tenant_id' column to security-group-list.

[1]: http://paste.openstack.org/show/481917/

Revision history for this message
Hong Hui Xiao (xiaohhui) wrote :

IMO, I don't think it is bug, as I can see the same thing happens elsewhere.

[1] http://paste.openstack.org/show/481944/

Revision history for this message
Carl Baldwin (carl-baldwin) wrote :

I tend to think this is not a bug. After all, the name of an object, whether security group or other, was never meant to be unique in any context including within a single tenant. The uuid is meant to be the only distinguisher that we can always count on to be unique in any context.

I'm assuming that the user can easily request that the tenant_id (project_id) or some other distinguishing column to the results using the -c option to the client. I'm hesitant to add this to the list of columns in every case. Is this the case?

Changed in python-neutronclient:
status: New → Incomplete
Revision history for this message
Manjeet Singh Bhatia (manjeet-s-bhatia) wrote :

I agree we have lot of object that can have same name in openstack.

otherwise it would be a mess. different tenants may not be able to get names for objects they want.
I think its an invalid bug.

Revision history for this message
Akihiro Motoki (amotoki) wrote :

We have a solution to use -c option so that tenant_id field is displayed in such case.

On the other hand, it is useful to display tenant_id automatically when a user has an admin role.
I think it is a valid feature request. Thought?

We can check if a user has 'admin' role by checking roles of keystone information.
One bad point is that the role name of 'admin' needs to be hardcoded.

Changed in python-neutronclient:
importance: Undecided → Wishlist
assignee: nobody → Akihiro Motoki (amotoki)
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
status: Incomplete → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/265503

Changed in python-neutronclient:
status: Triaged → In Progress
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

This bug is > 180 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in python-neutronclient:
assignee: Akihiro Motoki (amotoki) → nobody
status: In Progress → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for python-neutronclient because there has been no activity for 60 days.]

Changed in python-neutronclient:
status: Incomplete → Expired
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/265503
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=9dbdced729f6d7750307092d10a9737867a5b01c
Submitter: Jenkins
Branch: master

commit 9dbdced729f6d7750307092d10a9737867a5b01c
Author: Akihiro Motoki <email address hidden>
Date: Sat Jan 9 13:18:36 2016 +0900

    Show tenant_id in *-list by admin

    If API call is done by admin, neutron API returns all resources
    from all tenants. We received several times a request that
    tenant_id is useful in such case.

    This patch displays tenant_id column when *-list is invoked
    by a user with 'admin' role by default. If columns to be displayed
    are specified by '-c' option, the specified columns are honored
    and tenant_id columns is not added.

    Add functional tests to cover this change. This feature depends
    on keystoneauth1 and unit tests cannot cover this change.

    Closes-Bug: #1526238
    Change-Id: Id58a0b795f76b4fe24aaf89f1f6486c23f19a553

Changed in python-neutronclient:
status: Expired → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-neutronclient 6.1.0

This issue was fixed in the openstack/python-neutronclient 6.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.