Web client: Checkout auto renew age OU setting is not honored

[Kathy Lussier]

Tested on a system with a checkout auto renew setting of 6 days. In the web client, when I attempted to check out an item to a patron who already had the item checked out for more than 6 days, I received a prompt asking me if I wanted to renew the item or cancel the transaction. The expected behavior is for the client to automatically renew the item without a prompt.

[Billy Horn (bhorn)]

I have pushed a commit here http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bhorn/LP1526163-checkout-auto-renew-not-honored

It adds a check during checkout for the auto renew policy and also adds a check to make sure the items out count doesn't increase if the current transaction is a renew.

[Bill Erickson (berick)]

Thanks, Billy.

I have pushed a new branch here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1526163-webstaff-auto-renew

It includes a sign-off for Billy's code, plus a secondary commit:

==
Initiate the auto-renewal earlier in the checkout process, specifically before checkout response data is unnecessarily fleshed. Add an explicit auto_renew toggle to the checkout response blob to more clearly indicate why checkout counts are not modified.

Additional code comments and logging.
==

[Kathy Lussier (klussier)]

It works for me. Pushed to master for inclusion in 2.12. Thank you Billy and Bill!