Wincondition artifacts could be choosen if no artifacts are available in map

[kaputtnik]

Seen in r7669.

Steps to reproduce:

1. Start editor
2. Place a player
3. Save the map
4. Start a game and chose the previous saved map

Result: Win condition artifact could be chosen.

The tag "artifacts" is always stored in the "elemental" file of the map.

[wl-zocker (wl-zocker)]

I can confirm this in r7662. Placing a player is not even necessary. There seems to be no way to get rid of the "artifacts" tag in the elemental file.

I am quite sure that this is a regression because when the feature was implemented, the win condition could only be chosen for maps with artifacts.

[GunChleoc (gunchleoc)]

The bg is in the editor file writing I guess, so we might not have noticed it at the time.

[kaputtnik (franku)]

There is also another failure of editor file writing, but i haven't found how to reproduce it. Under some circumstances, after the players are set and the map is saved, reopening the map triggers the error:

Game data error
allowed buildings: player 2 (barbarians): [/home/kaputtnik/Quellcode/widelands-repo/trunk/src/profile/profile.cc:643] in "" section [player_2] not found

This is may caused by trying to set a player position to an invalid place, but this seems not to be the real reason for this error because it happens sometimes, sometimes not. I will file a new bugreport for this, if i found how to reproduce it.

[wl-zocker (wl-zocker)]

This bug happens indeed in r7627 (the revision in which the artifacts branch has been merged).

[wl-zocker (wl-zocker)]

I believe the problem is that all world immovables are checked, instead of just the ones on the map:
http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/logic/map.cc#L2067

If someone told be how to call this function for the whole map, I could try to fix it:
 uint32_t find_immovables
  (const Area<FCoords>,
   std::vector<ImmovableFound> * list,
   const FindImmovable & = find_immovable_always_true());

[kaputtnik (franku)]

Just a reminder :-)

Revising maps for build 19 couldn't be done if this isn't fixed.... Otherwise one has to search each map and check if there are artifacts and maybe remove the tag "artifacts" from the elemental file by hand isn't really fun :D

[kaputtnik (franku)]

Crash when trying to select a map in Editor menu "Load map".

[GunChleoc (gunchleoc)]

This is the problem with the suggested teams box reported in https://bugs.launchpad.net/widelands/+bug/1543944

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.