Make repositories configurable

[David Moreau Simard]

It would be nice to be able to feed a configuration to manifests/repos.pp, this way we could run integration tests on different repositories without resorting to different branches.

Example use case: master branch points to the current-passed-ci repository (like in https://review.openstack.org/#/c/255635/) but I want to test the current repository without having to modify repos.pp.

[Emilien Macchi (emilienm)]

Big +1 on that. I'm also thinking at being able to disabling repo management the day we gate upstream packaging with Puppet jobs.

Example:
I submit a patch in packaging, CI is starting.
Puppet jobs start (it spawns a VM) and deploy repos "manually" (without Puppet) with a specific delorean URL. And then Puppet tasks can start.

What do you think?

[David Moreau Simard (dmsimard)]

Either way is fine.
It's probably simpler to set up the repositories outside/before run_tests.sh and rip out the repository management from integration tests entirely.
I see value in testing that the repository classes work well, though - but perhaps that can be another test (i.e, we do integration tests on ::openstack_extras::repo::* in another scenario or something)

[David Moreau Simard (dmsimard)]

Review here: https://review.openstack.org/#/c/258136/

[Alan Pevec (apevec)]

@David @Emilien - review was merged, anything else left on puppet-openstack side?

[David Moreau Simard (dmsimard)]

Unless Emilien wants to make repositories actually configurable (which is fairly complex to do right) I settled with turning off the repository configuration so we can configure the repositories ourselves before running the integration tests. This is indeed merged and I've started working on a branch to get this going in weirdo.