OpenStack Dashboard (Horizon)

action_present and action_past attributes have to be deprecated in favor of action_present and action_past methods

Bug #1525309 reported by Yves-Gwenael Bourhis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Yves-Gwenael Bourhis
OpenStack Dashboard (Horizon) mitaka-3 "m3"

Bug Description

actions.BatchAction subclasses need to use action_present and action_past methodes and triger a deprecation warning when using attributes
If we don't do so, attributes will ever come back and are not translatable.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/256567

Changed in horizon:
assignee: nobody → Yves-Gwenael Bourhis (yves-gwenael-bourhis)
status: New → In Progress
David Lyle (david-lyle)
Changed in horizon:
milestone: none → mitaka-3
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/256567
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b313c4c40daeeb3cc141b36fcf28b2aa7ec496d5
Submitter: Jenkins
Branch: master

commit b313c4c40daeeb3cc141b36fcf28b2aa7ec496d5
Author: Yves-Gwenael Bourhis <email address hidden>
Date: Fri Dec 11 17:19:47 2015 +0100

    Changed to DeprecationWarning in BatchAction.

    BatchAction class was triggering a PendingDeprecationWarning
    We now have to trigger a DeprecationWarning to ensure new code does not come
    with the old attribute style of action_present and action_past.

    Change-Id: I3c4b212d6a42cdf7466d1df5a74d679349bf9e9a
    Closes-Bug: #1525309

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b3

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.