pacemaker SysInfo incorrectly determines free disk space

[Ivan Berezovskiy]

Pacemaker fails to start any resource on hardware environment with the following configuration:

1. Neutron VLAN
2. One or two controllers.
3. No cinder, no Ceph.

Error log:
http://paste.openstack.org/show/481458/

Check pacemaker log:

grep 'has an combined system health' /var/log/pacemaker.log | less

Result is -1000000

The reason is that SysInfo resource reports that disk space is low, as df -h by default returns disk space amount in TB if it's large enough and the script compares the amount of space to values in Megabytes.

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "275"
  build_id: "275"
  fuel-nailgun_sha: "5ff92bf8e121390ccdfb53cd0c4a1503fb731f5a"
  python-fuelclient_sha: "19b89d9109d7ddffdc0eb4c4c0979485f3ca2146"
  fuel-agent_sha: "6356e90686efcc0f5aa1c6bfc108688975ce9650"
  fuel-nailgun-agent_sha: "a33a58d378c117c0f509b0e7badc6f0910364154"
  astute_sha: "48fd58676debcc85951db68df6d77c22daa55e52"
  fuel-library_sha: "f267761dff972295bc32b42934a13568a2d1725d"
  fuel-ostf_sha: "23b7ae2a1a57de5a3e1861ffb7805394ca339cc2"
  fuel-mirror_sha: "c66309976db831a4081e5e0064028d7c67014b2f"
  fuelmenu_sha: "761685b566af981479e7e0f3c3a5eede5a40400d"
  shotgun_sha: "a0bd06508067935f2ae9be2523ed0d1717b995ce"
  network-checker_sha: "a3534f8885246afb15609c54f91d3b23d599a5b1"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "95b4232a4faf0eb151fcc9aefca833392afa6cdf"

[Ivan Berezovskiy (iberezovskiy)]

https://review.fuel-infra.org/#/c/14563/

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/14563
Submitter: Pkgs Jenkins <email address hidden>
Branch: 8.0

Commit: 410c5bfe7718a4f440eebd951d0ea400721b57f0
Author: Sergey Kolekonov <email address hidden>
Date: Fri Dec 18 15:57:24 2015

Fix disk space checker in SysInfo resource

df -h by default returns a result in the most readable values, e.x on small
disks it will be megabytes and on large (> 1 Tb) it is TB. To properly compare
disk space to the limits the specific unit should be used - megabytes (df -BM)

Closes-bug: #1524729
Change-Id: I49686ae0df9e78f9b5a43765a3a59739064560a0

[Kristina Berezovskaia (kkuznetsova)]

Verify on
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "478"
  build_id: "478"
  fuel-nailgun_sha: "ae949905142507f2cb446071783731468f34a572"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "481ed135de2cb5060cac3795428625befdd1d814"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "420c6fa5f8cb51f3322d95113f783967bde9836e"
  fuel-ostf_sha: "ab5fd151fc6c1aa0b35bc2023631b1f4836ecd61"
  fuel-mirror_sha: "b62f3cce5321fd570c6589bc2684eab994c3f3f2"
  fuelmenu_sha: "fac143f4dfa75785758e72afbdc029693e94ff2b"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "6c6b088a3d52dd0eaf43d59f3a3a149c93a07e7e"

Deploying env with node with SLAVE_HDD_SIZE=2T. Env was deployed with successful results