Fuel for OpenStack

[library] ssl_add_trust_chain.pp is not idempotent

Bug #1524727 reported by Roman Sokolkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Bartłomiej Piotrowski
Fuel for OpenStack 8.0
7.0.x
Won't Fix
Medium
Unassigned
Fuel for OpenStack 7.0-updates

Bug Description

"add_trust" exec should have onlyif, unless or creates parameter to prevent permanent execution.

Affects MOS 7.0 and MOS 8.0.

Tags: area-library
Roman Prykhodchenko (romcheg)
Changed in fuel:
milestone: none → 8.0
assignee: nobody → Fuel Library Team (fuel-library)
importance: Undecided → Medium
status: New → Confirmed
tags: added: area-library
Bartłomiej Piotrowski (bpiotrowski)
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Bartłomiej Piotrowski (bpiotrowski)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/256975

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/256975
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=a4a7ca8aca0f528875e7a57dfe513105761a0e31
Submitter: Jenkins
Branch: master

commit a4a7ca8aca0f528875e7a57dfe513105761a0e31
Author: Bartłomiej Piotrowski <email address hidden>
Date: Sat Dec 12 21:46:29 2015 +0100

    Fix idempotence of ssl-add-trust-chain task

    Change-Id: Ie391f7fc2b53c8647ffba9a2fdd0c2895fd9968c
    Closes-Bug: 1524727

Changed in fuel:
status: In Progress → Fix Committed
Andrey Lavrentyev (alavrentyev)
tags: added: on-verification
Revision history for this message
Mikhail Samoylov (msamoylov) wrote :

Verified in fuel version:
cat /etc/fuel/version.yaml
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "529"
  build_id: "529"
  fuel-nailgun_sha: "baec8643ca624e52b37873f2dbd511c135d236d9"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "e2d79330d5d708796330fac67722c21f85569b87"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "e071216cb214e34b4d861478033425ee6a54a3be"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "a365f05b903368225da3fea9aa42afc1d50dc9b4"

Steps:
1. Create cluster with option:
Settings - Security - TLS for OpenStack public endpoints and then "I have my own keypair with certificate"
2. Create ssl custom cert add this cert in step settings tab from step 1
3. Deploy cluster
4. SSH to controller node and run
puppet apply -v --noop /etc/puppet/modules/osnailyfacter/modular/ssl/ssl_add_trust_chain.pp

Expected output:
http://paste.openstack.org/show/487131/

Actual output:
http://paste.openstack.org/show/487131/

tags: removed: on-verification
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.