[library] netconfig task is not idempotent

[Roman Sokolkov]

I've ran netconfig task on deployed controller and got 33 resources out_of_sync

Environment: MOS 7.0, probably the same for MOS 8.0

How to check:
1) Deploy any environment
2) Run "puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/netconfig/netconfig.pp"
3) Check "grep out_of_sync /var/lib/puppet/state/last_run_summary.yaml"

Expected result:
out_of_sync: 0

Actual result:
out_of_sync: 33

Details:
puppet output - http://paste.openstack.org/show/481457/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/260655

[Roman Sokolkov (rsokolkov)]

Proposed fix is for other bug.

[Ivan Ponomarev (ivanzipfer)]

Roman,
I agree, anyway my commit partially fix bug related with sysfs which you can find in puppet output.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/260655
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=05efae8a1c0ed4cda49de334692f1ed7447deb9d
Submitter: Jenkins
Branch: master

commit 05efae8a1c0ed4cda49de334692f1ed7447deb9d
Author: Ivan Ponomarev <email address hidden>
Date: Tue Dec 22 11:20:48 2015 -0600

    fix sysfs idempotence

     - Change notify from sysfs class to sysfs service
     - Remove ubuntu tweak

    Partial-Bug: #1524724
    Change-Id: I93cc68bd0fcc46b7d506f194c0b16e6439f0632d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/292347

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/292347
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=d040c126d922a2495f94e1ce329cb279eea04557
Submitter: Jenkins
Branch: master

commit d040c126d922a2495f94e1ce329cb279eea04557
Author: Michael Polenchuk <email address hidden>
Date: Mon Mar 14 15:11:13 2016 +0300

    Fix sysfs service idempotency

    Sysfs is kind of "apply params" service, so status should always
    return true. Service's resource will prefer the 'status' parameter,
    then 'statuscmd' method, then look in the process table.

    Partial-Bug: #1524724
    Change-Id: I8a13ac4a227195cfb16be89c8fb0a9a9ec3ba1f0

[Alexey Shtokolov (ashtokolov)]

Since Fuel 9.1 we have noop deployment to detect changes. Netconfig generates a huge list of changed parameters. It leads to ugly UX. Raise to High